The Btfinex module allows you to interact with the Bitfinex Cryptocurrency Exchange Platform.

Including supplies the following services:

Comments

Anatolii1309 created an issue. See original summary.

anatolii1309’s picture

Issue summary: View changes
anatolii1309’s picture

Issue summary: View changes
avpaderno’s picture

avpaderno’s picture

avpaderno’s picture

Priority: Normal » Critical

I changed the issue priority as described on Review process for security advisory coverage: What to expect / Application Review Timelines.

To reviewers: Please change back the priority to Normal after reviewing the project.

avpaderno’s picture

Priority: Critical » Normal
Status: Needs review » Needs work
  • What follows is a quick review of the project; it doesn't mean to be complete
  • For every point, the review doesn't make a complete list of lines that should be fixed, but an example of what is wrong in the code
  • A review is about code that doesn't follow the coding standards, contains possible security issue, or doesn't correctly use the Drupal API; if a point isn't about that, it makes it clear
  /**
   * {@inheritdoc}
   */
  public static function create(ContainerInterface $container) {
    return new static(
      $container->get('config.factory'),
      $container->get('http_client'),
      $container->get('logger.factory')
    );
  }

A service class doesn't implement that method, as Drupal reads the .services.yml file to understand which parameters need to be passed to its constructor.

anatolii1309’s picture

Status: Needs work » Needs review

Thanks for your review. I have corrected the code.

avpaderno’s picture

Assigned: Unassigned » avpaderno
Status: Needs review » Fixed

Thank you for your contribution! I am going to update your account.

These are some recommended readings to help with excellent maintainership:

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.