Pulling channels with drush one by one is a nice option, but often we want to simply pull them all at once. I'll provide an MR to resolve this and hope you want to integrate this into the module.

Issue fork entity_share-3223470

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jurgenhaas created an issue. See original summary.

jurgenhaas opened merge request !11

jurgenhaas’s picture

jurgenhaas
he/him
Primary language German
Location Gottmadingen
commented
Status: Active » Needs review

Please have a look at the MR.

Grimreaper made their first commit to this issue’s fork.

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented

Hello,

Thanks for the MR. I will try to give it a look.

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented

Hello @jurgenhaas,

Thanks a lot for this Drush command. Very instructive review!

Could you please give your opinion on the remaining review points?

The other ones were just notes or coding standard that I fixed.

jurgenhaas’s picture

jurgenhaas
he/him
Primary language German
Location Gottmadingen
commented

Thanks @Grimreaper for your great review. I've just commented on the 2 unresolved threads, none of which should be complicated to resolve, I hope.

  • Grimreaper committed 982b13c on 8.x-3.x authored by jurgenhaas 
    Issue #3223470 by jurgenhaas, Grimreaper: Add drush command to pull all...
grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Status: Needs review » Fixed

Merged!

Thanks!

Chidl issue created #3228718: Change Drush command options into arguments

spuky’s picture

spuky commented
Status: Fixed » Needs review

I am not sure if this is working as expected...

tried the dev version...

old single channel syntax 

drush entity-share-client:pull --remote-id=remote_site --channel-id=channel1_de --import-config-id=import_all

is importing / updating entities...

new syntax

drush entity-share-client:pull-all remote_site import_all

is outputting...

Synchronizing channel1_de
Synchronizing channel1_en
Synchronizing channel2_de
Synchronizing channel2_en

but nothing happens...

am I doing something wrong...

Remote Site is still on 8.x-3.0-beta4 (if that matters)

  • Grimreaper authored 4a197d5 on 8.x-3.x 
    Issue #3223470 by jurgenhaas, Grimreaper, spuky: Fix Drush command call...
grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Status: Needs review » Fixed

Very nice catch @spuky!

I wonder how I had tested the MR previously and seen it working...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.