[D8] WalkMe Snippet

• What follows is a quick review of the project; it doesn't mean to be complete
• For every point, I didn't make a complete list of where the files should be fixed, but an example of what is wrong
• The review points report what should be changed to follow the Drupal coding standards, correctly use the Drupal API, or avoid any (possible) security issue; if a review point isn't about one of those topics, the point makes that clear

The Drupal\Core\Render\Markup class is an internal class not thought to be used from contributed modules.

  catch (\Exception $e) {
    return FALSE;
  }

hook_page_attachments() implementations aren't expected to return values.

Only Drupal core can use a class that is marked as internal; that is what comment #27 is saying. That comment is also suggesting a way to avoid using the Markup class.

For what I can see, since the Markup class is using MarkupTrait and that Drupal 8 and 9 backwards compatibility and internal API policy (backend) doesn't say traits are implicitly internal, a class using that trait (which does all the work) would be sufficient.

I changed the issue priority as described on Review process for security advisory coverage: What to expect / Application Review Timelines.

To reviewers: Please change back the priority to Normal after reviewing the project.

Thank you for your contribution! I am going to update your account.

These are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.