This module is a extension of "Layout Builder" and provides a complete package of components and new features integrated with that system, functionality that is available on Drupal 8 and is already fully supported by Drupal 9.
With this module we want to extend the user experience by creating an improved interface, much more customizable and with aspects that are essential for us, such as the live preview of the changes while editing the content.
Project link
https://www.drupal.org/project/layoutcomponents
Git instructions
git clone --branch '3.0.x' https://git.drupalcode.org/project/layoutcomponents.git
PAReview checklist
http://pareview.net/r/264
Comments
Comment #2
avpadernoComment #3
dcraig91 commentedComment #4
avpadernoComment #5
dcraig91 commentedHello,
I have fixed the related errors but i don't know what i have to do with "It appears you are working in the "3.0.x" branch in git", i have deleted the branch "3.0.0" and now is "3.0.x" but the error is still appearing
"Line indented incorrectly; expected at least 14| | spaces, found 12" in LcBase.php, the line intended is correct, if i try to set it with 14 spaces the errorr change from 12 to 14 again.
Comment #6
avpaderno3.0.x is a correct branch name. PAReview is expecting a branch like 8.x-1.x, which was the only type of branch acceptable before drupal.org allowed projects to follow semantic versioning.
I don't see any indentation issues for the reported lines, for example the last one in the following code.
The last line is indented by 12 spaces, and the next one, containing the closing parenthesis for the array, by 10 spaces. It seems PAReview is getting confused, probably because some array items are array and that item is a string.
Those are definitively false positives.
I will review the project in the next hour.
Comment #7
avpadernoI didn't find any apparent security issue.
The LcCopyRemove class, which implement a confirmation form, should extend the
ConfirmFormBaseclass.The namespace of the dependencies is wrong.
The part before the colon is the project machine name for the project that contains the module. It's drupal only for Drupal core modules. For the Entity Reference Revisions module, for example, it's entity_reference_revisions, but for the Devel Generate module, it's devel, since that module is included in the Devel project.
The user permissions should contain a verb and a direct object, such as in administer users or bypass node access.
Comment #8
avpadernoThank you for your contribution! I am going to update your account.
These are some recommended readings to help with excellent maintainership:
You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.