Deprecate file_build_uri()

Removed usages in core.

The patch looks good, only the deprecation message test is missing.

Created a CR.

The patch also needs to link to the CR.

Tagging

Adds deprecation test and links to CR.

+++ b/core/includes/file.inc
@@ -95,8 +95,14 @@ function file_url_transform_relative($file_url) {
+  @trigger_error('file_build_uri() is deprecated in drupal:9.3.0 and is removed from drupal:10.0.0 without replacement. See https://www.drupal.org/node/3223016', E_USER_DEPRECATED);

this is linking to the issue, not the CR.

I reviewed and updated the CR a bit to clarify, that in many cases, you should either provide configuration that includes the scheme or if the path is hardcoded, you don't need to normalize it.

Oops! Good catch.

Thanks, back to RTBC then.

+++ b/core/modules/system/system.module
@@ -1175,7 +1175,9 @@ function system_retrieve_file($url, $destination = NULL, $managed = FALSE, $repl
   /** @var \Drupal\Core\File\FileSystemInterface $file_system */
   $file_system = \Drupal::service('file_system');
   if (!isset($destination)) {
-    $path = file_build_uri(\Drupal::service('file_system')->basename($parsed_url['path']));
+    $path = $file_system->basename($parsed_url['path']);
+    $path = \Drupal::config('system.file')->get('default_scheme') . '://' . $path;
+    $path = \Drupal::service('stream_wrapper_manager')->normalizeUri($path);
   }
   else {

FWIW, system_retrieve_file() is another thing we should deprecate, maybe with, maybe without exact replacement. It's one of those helper functions that directly display messags and can't be used with proper error handling. But that's very much a separate issue and might already have one.

Created #3223205: deprecate system_retrieve_file() without replacement as a follow up.

Accidental status change I asusme?

Yes. My mistake.

Good idea to just remove, doesn't even meet the rule of three in core.

Committed d6e4a29 and pushed to 9.3.x. Thanks!