This module provides a Node Randomizer block with a link that redirects user to a random published node within the site. This can be used to create a feature like READ RANDOM [INSERT CONTENT TYPE] . The module also comes with global configuration to include specific content types. On block level user can choose to use simple text or material icon when the block is rendered.

Project link

https://www.drupal.org/project/node_randomizer

Git instructions

git clone --branch '1.0.x' https://git.drupalcode.org/project/node_randomizer.git

PAReview checklist

http://pareview.net/r/257

Comments

AalokAtre created an issue. See original summary.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Issue summary: View changes
AalokAtre’s picture

AalokAtre commented

Thanks for the initial review :
1) Readme.txt updated for the project.
2) hook_help is now implemented.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented

Thank you for applying! Reviewers will check the project and post comments to list what should be changed.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Priority: Normal » Critical

I changed the issue priority as described on Review process for security advisory coverage: What to expect / Application Review Timelines.

To reviewers: Please change back the priority to Normal after reviewing the project.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Priority: Critical » Normal
Status: Needs review » Needs work
  • What follows is a quick review of the project; it doesn't mean to be complete
  • For every point, the review doesn't make a complete list of lines that should be fixed, but an example of what is wrong in the code
  • A review is about code that doesn't follow the coding standards, contains possible security issue, or doesn't correctly use the Drupal API; if a point isn't about that, it makes it clear
  /**
   * The config factory.
   *
   * @var \Drupal\Core\Config\ConfigFactoryInterface
   */
  protected $configFactory;

That property is already defined from the parent class; there is no need to declare it again. This also means the class constructor needs to be changed.

    $content_types = $this->configFactory->get('node_randomizer.settings')->get('enabled_content_types');

The parent class implement config() to get a configuration object.

AalokAtre’s picture

AalokAtre commented
Status: Needs work » Needs review

Updated branch 1.0.x as per review comments.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Assigned: Unassigned » avpaderno
Status: Needs review » Fixed

Thank you for your contribution! I am going to update your account.

These are some recommended readings to help with excellent maintainership:

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.