Hello Team,

I have solved possible all the coding standards. Please check and merge my PR in the next release.

Thanks,
--Ken

CommentFileSizeAuthor
#4 3222108_spelling_error.png41.99 KBhmendes
#2 3222108_phpcs.png31.99 KBhmendes

Issue fork views_field_view-3222108

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Ken Patolia created an issue. See original summary.

hmendes’s picture

hmendes commented
Category: Support request » Task
Status: Active » Needs work
StatusFileSize
new 3222108_phpcs.png31.99 KB

When running phpcs it still show these errors. Maybe we could fix them here?

Ken Patolia’s picture

Ken Patolia commented

Hi @hmendes,

Thanks for the review, my PR.

I have updated my PR again, please check.

Thanks,
--Ken

hmendes’s picture

hmendes commented
StatusFileSize
new 3222108_spelling_error.png41.99 KB

Hello!
Now all the errors are fixed, just change the word "ascening" back to "ascending" and it's ready to RTBC.

Ken Patolia’s picture

Ken Patolia commented

Hi @hmendes,

First of all thanks for reviewing my PR. You are doing really great job.

Anyway, I have updated my PR please check.

Thanks
--Ken

hmendes’s picture

hmendes commented
Status: Needs work » Reviewed & tested by the community

Hello, now I thinks that's perfect.
Moving to RTBC, thanks.

vladimiraus’s picture

vladimiraus
Primary language English
Location Brisbane 🇦🇺
commented
Related issues: +#3568919: Improve CI coverage

Thank you everyone for your contributions.
Merged. 🍻
Might be similar to #3568919: Improve CI coverage.

vladimiraus opened merge request !19

vladimiraus’s picture

vladimiraus
Primary language English
Location Brisbane 🇦🇺
commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.