Problem/Motivation

Can't add specific view exposed form id in antibot setting to protected by antibot. don't want to activate antibot for all views exposed forms with form id "views_exposed_form".

CommentFileSizeAuthor
#5 allow-specific-view-form_3221723_1.patch721 bytesgawade.nagesh

Issue fork antibot-3221723

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

gawade.nagesh created an issue. See original summary.

gawade.nagesh’s picture

gawade.nagesh commented
Assigned: Unassigned » gawade.nagesh

gawade.nagesh opened merge request !3

gawade.nagesh closed merge request !3

gawade.nagesh’s picture

gawade.nagesh commented
Status: Active » Needs review
StatusFileSize
new allow-specific-view-form_3221723_1.patch721 bytes

Here is the patch.

gaurav.kapoor’s picture

gaurav.kapoor commented

#5 works for me.

I was able to reproduce this issue and see that as of now if we add form id of a view exposed form (Eg: 'views-exposed-form-content-page-1') in the antibot settings, then antibot doesn't work.

After, applying the patch, the antibot starts working for specific exposed views exposed form as well.

I Will keep this issue open for now to get more feedback regarding the patch and we should also add a test specific to views exposed form as well.

Thanks for working on this @gawade.nagesh.

gaurav.kapoor’s picture

gaurav.kapoor commented
Assigned: gawade.nagesh » Unassigned
paulocs’s picture

paulocs
Primary language Portuguese, Brazil
Location Belo Horizonte
commented

@gaurav.kapoor how did you test it?

It looks like the form wasn't submitted before the patch as well but the form is not redirected to /antibot...

gaurav.kapoor’s picture

gaurav.kapoor commented

@paulocs, here is how I tested it:

1. Add form ID of a view exposed form (Eg: 'views-exposed-form-content-page-1') to antibot settings.
2. The antibot module starts working for specific exposed views forms now, rather than all of them.

So with this users don't have to enable antibot for all the exposed view forms. With a slight tweak in deciding which forms to alter, we are able to have this feature.

Let me know if I am missing anything.

gaurav.kapoor’s picture

gaurav.kapoor commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.