When a user is never logged in the account is not blocked

Problem/Motivation

When a test user is never logged in the account is not blocked.

Steps to reproduce

1. Create a new test account.
2. Run cron
3. Account is not blocked

Proposed resolution

In \Drupal\role_test_accounts\RoleTestAccountsManager::setStatusForRoleTestAccounts replace

      foreach ($this->getAllRoleTestAccounts() as $user) {
        if ($user->getLastAccessedTime()) {
          if ($user->isActive() && ($this->time->getRequestTime() - $block_after) > $user->getLastAccessedTime()) {
            $user->block();
            $user->save();
          }
          elseif ($user->isBlocked() && ($this->time->getRequestTime() - $block_after) < $user->getLastAccessedTime()) {
            $user->activate();
            $user->save();
          }
        }
      }

with

      foreach ($this->getAllRoleTestAccounts() as $user) {
        if ($user->isActive() && ($this->time->getRequestTime() - $block_after) > $user->getLastAccessedTime()) {
          $user->block();
          $user->save();
        }
        elseif ($user->isBlocked() && ($this->time->getRequestTime() - $block_after) < $user->getLastAccessedTime()) {
          $user->activate();
          $user->save();
        }
      }

Remaining tasks

• Create patch
• Review patch