Problem/Motivation

Modal is full width on Claro when using the experimental modal widget, see screenshot

See #3191527: Dialog width and positioning issues in Claro for the core issue that might someday fix this, credit @bnjmnm for looking into it
Original patch posted to #3028468: Use Drupal dialog instead of directly using jQuery dialog for add modal, but this needs a new issue so created this. Patch credit @kvantstudio

Steps to reproduce

Do a clean install of D9 Umami
set Claro as the admin theme
Add a prargraph field and set the form widget to use the experimental modal version
Add a paragraph to a node

Proposed resolution

Not make the modal full width.

Remaining tasks

Decide if this is something that needs to be fixed in Paragraphs or in core.

User interface changes

The modal is no longer full width.

CommentFileSizeAuthor
#7 screenshot2.PNG12.85 KBgaurav-mathur
#7 screenshot1.PNG11.97 KBgaurav-mathur
#2 Screenshot_20210914_113249.png71.15 KBtaniachque
#2 Screenshot_20210914_113817.png82.92 KBtaniachque
paragraphs-use-drupal-dialog-3028468-27.patch451 byteslendude
Screenshot 2021-06-30 at 09.58.04.png388.2 KBlendude

Comments

Lendude created an issue. See original summary.

taniachque’s picture

taniachque commented
StatusFileSize
new Screenshot_20210914_113817.png82.92 KB
new Screenshot_20210914_113249.png71.15 KB

I could reproduce the problem and applying the patch the problem of full width was solved.
However, with the patch, the modal was not draggable anymore in Claro, Bartik and Seven. We will need to find another fix that does not break this.

mathilde_dumond’s picture

mathilde_dumond commented
Status: Active » Needs work
idebr’s picture

idebr commented
Status: Needs work » Closed (duplicate)
Related issues: +#3191527: Dialog width and positioning issues in Claro

This issue was fixed in Drupal Core, see #3191527: Dialog width and positioning issues in Claro

idebr’s picture

idebr commented
Title: Modal is full width on Claro when using the experimental modal widget » Enable autoResize for paragraphs modal
Status: Closed (duplicate) » Needs review

The original issue was fixed in Drupal Core. However, the patch fixes a different issue where the modal does not resize properly for large lists.

gaurav-mathur’s picture

gaurav-mathur commented
Assigned: Unassigned » gaurav-mathur
gaurav-mathur’s picture

gaurav-mathur commented
Assigned: gaurav-mathur » Unassigned
StatusFileSize
new screenshot1.PNG11.97 KB
new screenshot2.PNG12.85 KB

Its working fine without apply the patch, its look good for me,
I am tested in drupal 9.4.5,with Claro theme enabled as an admin theme.
(Added a paragraph type with a date field in article)
See Refer screenshot.

norman.lol’s picture

norman.lol
he/him
Primary language German
Location Berlin
commented
Status: Needs review » Reviewed & tested by the community

Yeah, with a long list of paragraphs and the screenlock you can't scroll in Claro. The patch fixes it.

  • Berdir committed 0a46561b on 8.x-1.x authored by Lendude 
    Issue #3221429 by Lendude: Enable autoResize for paragraphs modal
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Reviewed & tested by the community » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.