Tracking issue for stabilizing the 2.x branch. The plan is to begin with a thorough code review. That should reveal any areas of concern or tasks which should completed prior to publishing a stable release of the 2.x branch.
- #3228597: Upgrade path for "Disabled Items" feature from V1
- #3229555: Add Paragraph Behaviors Form Support
- #3220936: Conduct a code review
- #3211196: Add "Promote to library" / Paragraphs Library compatibility
- #3254382: Update API documentation in layout_paragraphs.api.php for 2.x branch
Set up automated tests on commit and on issues.-- We now have automated test coverage for most of the features of this module.
FROM #14 by @Anybody:
These are possibly relevant 2.x issues for the list above (important):
Possible bugs / feedback:
#3216981: All buttons being moved into modal actions
#3252978: Large modal exceeds viewport height without scrollbar = actions unreachable
#3228835: form-actions styles leak into paragraphs containing forms
#3253875: hook_layout_paragraph_element_form_alter not existing
#3223849: Provide layout info in hook_preprocess_paragraph
#3240086: Unable to remove paragraph added from Paragraphs library
#3230080: Use moveError validation for up and down arrows in addition to drag and drop
#3249006: Field template is missing with edit in-place.
#3200236: Module is not working for all layouts
#3218949: Javascript isn't compatible with html button
#3283720: Javascript error - Uncaught ReferenceError: dragula is not defined
#3276855: Passing null to parameter #1 ($string) of type string to mb_strtolower() is deprecated
#3297025: Edit buttons not accessible on small layouts or screens (responsiveness)
Usability:
#3254892: Improve UI / UX for (Un)published
#3244687: Improve usability for moving paragraphs between regions.
#3202220: If there is only one layout paragraph the widget should autoselect it
#3223474: Improve Styles
#3265669: Show loading spinner at layout selection, otherwise may select wrong layout (UI race condition)
Features:
#3218226: Cloning Entities containing Layout Paragraphs breaks structure (cloning)
#3246421: Improve organization of tests (tests)
Documentation:
#3189502: Project page Getting started steps are inadequate
#3205312: Link layout_paragraphs_restriction module
Perhaps split off a 2.1.0 release plan, for example with (nice to have's):
#3195510: Support default layouts and content for layout paragraphs
#3208180: Provide frontend editing experience for Layout Paragraphs.
#3231747: Add possibility to use layouts with paragraphs-experimental field widget
#3158244: Improve the content editor experience
#3166362: Add setting to limit what paragraph types can be in section layouts.
#3197059: Setting whether admin or front-end theme is used for paragraph edit forms
#3224488: Add ability to adjust column widths with widget UI
Deprecate and close 1.x issues
- 1.x should be deprecated with the release of 2.0.0.
- RTBC'd issues from 1.x should be committed and pushed for a final 1.1.0 release for anyone who still depends on 1.x to remove the need for these well tested patches.
- All other issues might be closed outdated?
Comments
Comment #2
gabesulliceCreated an issue for the code review, now adding it to the meta issue.
Comment #3
aaronpinero commentedI am considering using Layout Paragraphs for an upcoming project, but some of the developers working with me have concerns about starting a project with v1 of the module and later having to transition to v2. What is the expected upgrade path to v2? Is it intended to be relatively straightforward? Should we wait until there is a full release of v2? Any information would be helpful to us in making a determination about how to proceed.
Comment #4
anybody@gabesullice and @justin2pin, thank you very much for your hard work on 2.x. I have the same question as @aaronpinero and hope there will be a 100% upgrade path. Is that correct and to be expected?
Any updates on the 2.x branch? Can we perhaps help to push things forward? I think this project is VERY important for Drupal at all and I'm wondering if there shouldn't be further resourced available for help from the Drupal Community. Paragraphs benefits a lot from this project!
Does this project only have 2 (but great) maintainers / developers: itamair + justin2pin?
Comment #5
justin2pin commentedHey all - thanks for this. Here are a few comments / updates:
- First, importantly, YES there will be a simple upgrade path from V1 to V2. The underlying storage isn't changing at all. V2 introduces a number of APIs that other developers will be able to leverage for building modules with a broad range of add-on capabilities. V2 is a complete re-write, but drastically simplifies and improves the underlying code architecture. To upgrade, developers will simply need to switch to the new branch and clear caches.
- To reach 2.0.x Stable, we just need a complete suite of automated tests. The framework is in place, and there are a couple tests already added. I'd like to see automated tests written for all aspects of the module. So... if anyone wants to contribute additional tests, that would be a fantastic way to push this forward!
Comment #6
aaronpinero commentedThank you for the update. This is really great to hear. My experience so far with Layout Paragraphs has been really good and I think this is an excellent solution for providing content creators with better tools.
Unfortunately, I don't really have the ability to contribute to code tests -- I am only a front-end developer. But I just want to say thank you for all the work on this module.
Comment #7
pookmish commentedI've been building on the V2 for an upcoming site. I first explored the V1 and noticed that paragraph behavior forms are not currently implemented in V2.
I created ticket #3229555: Add Paragraph Behaviors Form Support for that feature.
Comment #8
pookmish commentedComment #9
thomas.frobieterI hate to ask this -_- But could anyone give an update of the current state? Is there a rough time window you have in mind?
We plan to migrate a huge site to Layout Paragraphs, and we try to figure out if it makes any sense to wait for 2.0 stable.
Comment #10
justin2pin commentedComment #11
justin2pin commentedComment #12
justin2pin commentedComment #13
justin2pin commentedComment #14
anybodyHi @justin2pin,
I just reviewed and commented some issues that might be relevant here, please have a look.
Also I guess a clarification in some 1.0.x issues might help about further development (switching the issues to 2.x) if there is no plan to put further maintainer time into 1.x, which would make sense, as I guess.
Perhaps also add a sentence like
on the module page and close (irrelevant) / switch over (relevant) 1.x issues?
These are possibly relevant 2.x issues for the list above (important):
Possible bugs / feedback:
#3216981: All buttons being moved into modal actions
#3252978: Large modal exceeds viewport height without scrollbar = actions unreachable
#3228835: form-actions styles leak into paragraphs containing forms
#3253875: hook_layout_paragraph_element_form_alter not existing
#3223849: Provide layout info in hook_preprocess_paragraph
#3240086: Unable to remove paragraph added from Paragraphs library
#3230080: Use moveError validation for up and down arrows in addition to drag and drop
#3249006: Field template is missing with edit in-place.
#3200236: Module is not working for all layouts
#3218949: Javascript isn't compatible with html button
#3283720: Javascript error - Uncaught ReferenceError: dragula is not defined
#3276855: Passing null to parameter #1 ($string) of type string to mb_strtolower() is deprecated
Usability:
#3254892: Improve UI / UX for (Un)published
#3244687: Improve usability for moving paragraphs between regions.
#3202220: If there is only one layout paragraph the widget should autoselect it
#3223474: Improve Styles
#3265669: Show loading spinner at layout selection, otherwise may select wrong layout (UI race condition)
#3297025: Edit buttons not accessible on small layouts or screens (responsiveness)
Features:
#3218226: Cloning Entities containing Layout Paragraphs breaks structure (cloning)
#3246421: Improve organization of tests (tests)
Documentation:
#3189502: Project page Getting started steps are inadequate
#3205312: Link layout_paragraphs_restriction module
Perhaps split off a 2.1.0 release plan, for example with (nice to have's):
#3195510: Support default layouts and content for layout paragraphs
#3208180: Provide frontend editing experience for Layout Paragraphs.
#3231747: Add possibility to use layouts with paragraphs-experimental field widget
#3158244: Improve the content editor experience
#3166362: Add setting to limit what paragraph types can be in section layouts.
#3197059: Setting whether admin or front-end theme is used for paragraph edit forms
#3224488: Add ability to adjust column widths with widget UI
What do you think?
Hope I was able to structure and help you a bit... :)
Comment #15
justin2pin commentedComment #16
finn lewisI'm keen to get Layout Paragraphs 2.x into LocalGov Drupal distribution, the UX is so much better, thanks for your amazing work!
If we can find time to help with some of the issues towards a stable 2.0.0 release, we will.
With this in mind, it would be good to confirm which of the issues in Anybody's comment above are blockers to a release. Perhaps we could update the issue description with the important issues?
Comment #17
anybodyUpdated the issue summary with the suggestions from #14 and updated the list.
Comment #18
anybodyComment #19
anybodyComment #20
anybody@justin2pin? As 2.0.0 is out, this could be set Fixed or Won't fix. Anyway it would be cool, if you could look through the listed issues.
For example, #3297025: Edit buttons not accessible on small layouts or screens (responsiveness) is major, I think.
Thanks a lot!
Comment #21
stijn.blomme commentedMaybe it's a good idea to add the restriction of paragraph types to certain regions as a feature for the 2.x release (or 2.1+)?
This feature would greatly improve the useability of the module for projects with a large sum of paragraph types.
At the moment this is linked under Documentation, but the paragraphs_restriction module is only supporting the 1.x branch of this module.
Comment #22
anybodyComment #23
justin2pin commentedComment #24
justin2pin commented@Anybody - thanks for your comment in #20. I'm going to leave the title on this one as it was and flag as fixed (as you recommended), since this issue was really just about getting to a stable 2x release. I'll post something separate -- either as a meta issue or in documentation -- about releases moving forward.
Comment #25
luongosb commentedIs Support revisions and content moderation with the Layout Paragraphs Builder Field Formatter on your radar?
Comment #26
emb03 commented+1 on #25