Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
Vertical Tabs that have #parents set, are broken after #3177415: Vertical Tabs CSS classes applying to non-vertical tab detail element groups. This could be tested on forms rendering vertical tabs in subforms, for example, on the editor config UI.
Proposed resolution
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
Comment | File | Size | Author |
---|---|---|---|
#10 | Screenshot_8_17_21__7_35_AM.png | 84.81 KB | mherchel |
#10 | Screenshot_8_17_21__7_33_AM.png | 122.38 KB | mherchel |
#6 | 3219340-6.patch | 2.66 KB | lauriii |
#6 | 3219340-6-test-only.patch | 1.62 KB | lauriii |
#5 | 3219340--5.patch | 2.82 KB | bnjmnm |
Comments
Comment #2
lauriiiComment #3
lauriiiRemoved unused use statement
Comment #4
lauriiiReuploading test only patch
Comment #5
bnjmnmSame as #4 (no additional changes), just removing the non-test stuff from the test-only patch.
Comment #6
lauriiiReuploading #4 but removing the fix from the test only patch
Comment #8
fathima.asmat CreditAttribution: fathima.asmat at Soapbox Communications Ltd commentedI can confirm that this patch is working for Drupal 9.2.x aswell. I had a similar issue with a paragraph with vertical tabs inside a details field group after I upgraded Drupal to 9.2 with Claro theme enabled. The patch #6 has fixed the problem. Thanks for the patch!
Comment #9
Spokje@fathima.asmat: Basically "fixed" is a status used when a patch is committed by a Core committter. This is not the case (yet).
Back to "Needs Review" and "9.3.x-dev" since that's the branch where fixes land before getting backported to 9.2.x by Core committers discretion.
Comment #10
mherchelThis works great!
Comment #12
SpokjeTriggered retest of
3219340-6.patch
so that will now become the patch that is 2-daily tested instead of3219340-6-test-only.patch
which should indeed fail.Comment #13
alexpottCommitted and pushed cbf7b5525e to 9.3.x and 1a6a815c96 to 9.2.x. Thanks!