Problem/Motivation

Vertical Tabs that have #parents set, are broken after #3177415: Vertical Tabs CSS classes applying to non-vertical tab detail element groups. This could be tested on forms rendering vertical tabs in subforms, for example, on the editor config UI.

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#10 Screenshot_8_17_21__7_35_AM.png84.81 KBmherchel
#10 Screenshot_8_17_21__7_33_AM.png122.38 KBmherchel
#6 3219340-6.patch2.66 KBlauriii
#6 3219340-6-test-only.patch1.62 KBlauriii
#5 3219340--5.patch2.82 KBbnjmnm
#5 3219340--5-test-only.patch1.79 KBbnjmnm
#4 3219340-3.patch2.66 KBlauriii
#4 3219340-3-test-only.patch2.66 KBlauriii
#3 interdiff.txt465 byteslauriii
#3 3219340-3.patch2.66 KBlauriii
#2 3219340-2.patch2.83 KBlauriii
#2 3219340-2-test-only.patch1.79 KBlauriii

Comments

lauriii created an issue. See original summary.

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Active » Needs review
StatusFileSize
new 3219340-2-test-only.patch1.79 KB
new 3219340-2.patch2.83 KB
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
StatusFileSize
new 3219340-3.patch2.66 KB
new interdiff.txt465 bytes

Removed unused use statement

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
StatusFileSize
new 3219340-3-test-only.patch2.66 KB
new 3219340-3.patch2.66 KB

Reuploading test only patch

bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
commented
StatusFileSize
new 3219340--5-test-only.patch1.79 KB
new 3219340--5.patch2.82 KB

Same as #4 (no additional changes), just removing the non-test stuff from the test-only patch.

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
StatusFileSize
new 3219340-6-test-only.patch1.62 KB
new 3219340-6.patch2.66 KB

Reuploading #4 but removing the fix from the test only patch

The last submitted patch, 6: 3219340-6-test-only.patch, failed testing. View results

fathima.asmat’s picture

fathima.asmat commented
Version: 9.3.x-dev » 9.2.x-dev
Status: Needs review » Fixed

I can confirm that this patch is working for Drupal 9.2.x aswell. I had a similar issue with a paragraph with vertical tabs inside a details field group after I upgraded Drupal to 9.2 with Claro theme enabled. The patch #6 has fixed the problem. Thanks for the patch!

spokje’s picture

spokje
Primary language Dutch
commented
Version: 9.2.x-dev » 9.3.x-dev
Status: Fixed » Needs review

@fathima.asmat: Basically "fixed" is a status used when a patch is committed by a Core committter. This is not the case (yet).

Back to "Needs Review" and "9.3.x-dev" since that's the branch where fixes land before getting backported to 9.2.x by Core committers discretion.

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Screenshot_8_17_21__7_33_AM.png122.38 KB
new Screenshot_8_17_21__7_35_AM.png84.81 KB

This works great!

The last submitted patch, 6: 3219340-6-test-only.patch, failed testing. View results

spokje’s picture

spokje
Primary language Dutch
commented

Triggered retest of 3219340-6.patch so that will now become the patch that is 2-daily tested instead of 3219340-6-test-only.patch which should indeed fail.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Version: 9.3.x-dev » 9.2.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed cbf7b5525e to 9.3.x and 1a6a815c96 to 9.2.x. Thanks!

  • alexpott committed cbf7b55 on 9.3.x 
    Issue #3219340 by lauriii, bnjmnm, mherchel: Vertical tabs with #parents...

  • alexpott committed 1a6a815 on 9.2.x 
    Issue #3219340 by lauriii, bnjmnm, mherchel: Vertical tabs with #parents...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.