Problem/Motivation

Drupal's overrides of Symfony's container need to be updated to support NULL services. This support was introduced in https://github.com/symfony/symfony/commit/28a1b5ac4779a5cac48b716e150b67... and Drupal needs the corresponding change.

Steps to reproduce

Define a service like:

    Acme\Foo: ~

Proposed resolution

Bring Drupal's YamlFileLoader inline with Symfony's

Remaining tasks

Make the same change
Add test coverage

User interface changes

None

API changes

Support for NULL services

Data model changes

None

Release notes snippet

N/a

CommentFileSizeAuthor
#2 3218968-2.patch1.68 KBalexpott
#2 3218968-2.test-only.patch965 bytesalexpott

Comments

alexpott created an issue. See original summary.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Active » Needs review
StatusFileSize
new 3218968-2.test-only.patch965 bytes
new 3218968-2.patch1.68 KB

Here's the fix from Symfony implemented in the Drupal YamlFileLoader and tested...

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Reviewed & tested by the community

Another small and straightforward one.

The last submitted patch, 2: 3218968-2.test-only.patch, failed testing. View results

  • catch committed c864977 on 9.3.x 
    Issue #3218968 by alexpott: Support NULL services in the container
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 9.3.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.