Problem/Motivation

There is a typo in the name of the (originally) tested function; however, search_simplify() was deprecated in #3075703: Move search text processing to a service and this now tests SearchTextProcessorInterface functionality. Rename accordingly (while we're at it.)

Steps to reproduce

Typo and deprecation!

Proposed resolution

Rename.

Remaining tasks

Review

User interface changes

n/a

API changes

n/a as this is a test only

Data model changes

None

Release notes snippet

Not needed, followup issue.

Issue fork drupal-3218562

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

bradjones1 created an issue. See original summary.

bradjones1 opened merge request !784

bradjones1’s picture

bradjones1
Primary language English
CreditAttribution: bradjones1 at Big Island Fish commented
Status: Active » Needs review

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Lendude’s picture

Lendude
Primary language Dutch
Location Amsterdam
CreditAttribution: Lendude as a volunteer and at iO commented
Status: Needs review » Needs work

Would it make sense to also update the test method names since those also still use searchSimplify?

  • testSearchSimplifyUnicode
  • testSearchSimplifyPunctuation

yogeshmpawar made their first commit to this issue’s fork.

yogeshmpawar’s picture

yogeshmpawar
He/Him/His
Primary language English
Location 🇮🇳 Pune(MH)
CreditAttribution: yogeshmpawar as a volunteer and at Portage CyberTech commented
Status: Needs work » Needs review
Lendude’s picture

Lendude
Primary language Dutch
Location Amsterdam
CreditAttribution: Lendude as a volunteer and at iO commented
Status: Needs review » Reviewed & tested by the community

@yogeshmpawar nice one also finding the reference in the comment.

Nice clean up, looks ready.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Needs work

One comment needs rewording again I think (see MR comment), otherwise looks good.

bradjones1’s picture

bradjones1
Primary language English
CreditAttribution: bradjones1 at Not Vanilla, Inc. commented
Status: Needs work » Needs review

Updated per feedback.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Needs review » Reviewed & tested by the community

Thanks that looks better.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
Version: 9.4.x-dev » 9.3.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed 34e0d0adeb to 10.0.x and 9e6666fb1f to 9.5.x and 88b3e1fa9c to 9.4.x and e74dad5819 to 9.3.x. Thanks!

Backported to 9.3.x as this is a test only.

  • alexpott committed 34e0d0a on 10.0.x 
    Issue #3218562 by bradjones1, yogeshmpawar, Lendude, catch: Fix typo in/...

  • alexpott committed 9e6666f on 9.5.x 
    Issue #3218562 by bradjones1, yogeshmpawar, Lendude, catch: Fix typo in/...

  • alexpott committed 88b3e1f on 9.4.x 
    Issue #3218562 by bradjones1, yogeshmpawar, Lendude, catch: Fix typo in/...

  • alexpott committed e74dad5 on 9.3.x 
    Issue #3218562 by bradjones1, yogeshmpawar, Lendude, catch: Fix typo in/...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.