Problem/Motivation

Notice: Trying to access array offset on value of type bool in S3fsStreamWrapper->_s3fs_get_object() (line 1239 of /var/www/html/docroot/sites/all/modules/s3fs/S3fsStreamWrapper.inc)

Proposed resolution

Patch forthcoming...

CommentFileSizeAuthor
#6 interdiff-3-6.txt595 bytesphma
#6 s3fs-StreamWrapper_access_offset_on_bool-3217718-6.patch683 bytesphma
#4 s3fs-StreamWrapper_access_offset_on_bool-3217718-4.patch677 bytesgeoffreyr
#3 s3fs-StreamWrapper_access_offset_on_bool-3217718-3.patch668 bytescsmdgl
#2 s3fs-StreamWrapper_access_offset_on_bool-3217718.patch824 bytescsmdgl

Comments

csmdgl created an issue. See original summary.

csmdgl’s picture

csmdgl commented
Status: Active » Needs review
StatusFileSize
new s3fs-StreamWrapper_access_offset_on_bool-3217718.patch824 bytes
csmdgl’s picture

csmdgl commented
StatusFileSize
new s3fs-StreamWrapper_access_offset_on_bool-3217718-3.patch668 bytes

Corrected patch

geoffreyr’s picture

geoffreyr commented
StatusFileSize
new s3fs-StreamWrapper_access_offset_on_bool-3217718-4.patch677 bytes

Same as #3 but rolled against 7.x-3.x.

phma’s picture

phma commented
Status: Needs review » Needs work

For me this patch breaks creation of imagecache derivatives when ignore_cache is set. If no metadata of an image has ever been cashed and $metadata is FALSE, it should still go and fetch those!

phma’s picture

phma commented
Status: Needs work » Needs review
StatusFileSize
new s3fs-StreamWrapper_access_offset_on_bool-3217718-6.patch683 bytes
new interdiff-3-6.txt595 bytes
cmlara’s picture

cmlara
he/him
commented
Status: Needs review » Closed (outdated)

Drupal 7 end-of-life triage:
Drupal 7 reached end of life on January 5th.

The 7.x branches of S3FS do not have any additional planned releases.

The requests in this issue do not appear to exist in the 8.x-3.x and newer branches.