This issue concerns Drupal 9 compatibility fixes to upgrade this module to Drupal 9
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | datetime_testing-drupal9_compatibility-3217303-4.patch | 9.44 KB | sinn |
Issue fork datetime_testing-3217303
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #3
sinn commenteddatetime_testing tests failed in PHPUnit 9 (that is used in Drupal 9) because time is printed differently because of PHPUnit\Framework\Assert::assertEquals() function parameters have been changed in this version.
PHPUnit <=8 : https://github.com/sebastianbergmann/phpunit/blob/8.5.15/src/Framework/Assert.php#L601
public static function assertEquals($expected, $actual, string $message = '', float $delta = 0.0, int $maxDepth = 10, bool $canonicalize = false, bool $ignoreCase = false): voidPHPUnit 9 https://github.com/sebastianbergmann/phpunit/blob/9.5/src/Framework/Asse...
public static function assertEquals($expected, $actual, string $message = ''): voidInstead of assertEquals() function assertEqualsWithDelta() should be used, but it appeared in PHPUnit 7.5.0. So I would suggest to set it as minimum version in require-dev in composer and replace assertEquals() by assertEqualsWithDelta().
Also in the tests please fix:
Comment #4
sinn commentedLet's try patch
Comment #5
ademarco commentedI've merged the MR. Closing.