Problem/Motivation

No test coverage for context with the user profile page condition.

Proposed resolution

Write a test for it.

Remaining tasks

1. Write a Kernel test.
2. Check/test that automated test passes.
3. Review and commit/merge the issue.

Issue fork context-3217119

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

DeaOm created an issue. See original summary.

DeaOm opened merge request !15

deaom’s picture

deaom commented
Status: Active » Needs review

The UserProfilePage condition does not have context_definitions in the annotations (but just context) so deprecation happens and test fails at least locally for me. The correction is added in the original issue #2942060: Addition of a User Condition, once that is merged test should be o.k. Setting status to needs review and if somebody will have issue testing locally, replace context with context_definitions.

deaom’s picture

deaom commented
Issue summary: View changes
paulocs’s picture

paulocs
Primary language Portuguese, Brazil
Location Belo Horizonte
commented
Status: Needs review » Reviewed & tested by the community

Thanks @DeaOm!

Amazing Job! :)

  • paulocs committed b61715a on 8.x-4.x authored by DeaOm 
    Issue #3217119 by DeaOm, paulocs: Add test for context Request Domain...
paulocs’s picture

paulocs
Primary language Portuguese, Brazil
Location Belo Horizonte
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.