Problem/Motivation
The module use the reserved word "Resource" as part of namespace, and it's generate a warning compatibility with php 7+.
See: http://php.net/manual/en/reserved.other-reserved-words.php
FILE: jsonapi_search_api/src/Resource/IndexResource.php
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
3 | WARNING | 'resource' is a soft reserved keyword as of PHP version 7.0 and should not be used to name a class, interface or trait or as part of a namespace (T_NAMESPACE)
--------------------------------------------------------
Steps to reproduce
run ./vendor/bin/phpcs -p jsonapi_search_api/ --runtime-set testVersion 7.4 --standard=PHPCompatibility --extensions=php,module,inc,install,test,profile,theme
Proposed resolution
Change the name from "Resource" to "JsonApiResource", the same happened with the json api core module, you can check here: https://www.drupal.org/project/jsonapi/issues/2971040
Comments