Given:
- a custom activity type without an "answer" component
- a non-mandatory module
- max score of zero

Expected:
- The result will be "passed", if the activity was completed, or "pending" if it was not

Observed:
- The result is always displayed "failed" because it has neither evaluation method nor answer type

CommentFileSizeAuthor
#2 opigno_learning_path-activity_type_status-3215553-2.patch701 bytesaaronbauman

Comments

AaronBauman created an issue. See original summary.

aaronbauman’s picture

aaronbauman
he/him
commented
Status: Active » Needs review
StatusFileSize
new opigno_learning_path-activity_type_status-3215553-2.patch701 bytes

If max_score for an activity is zero, show it either "pending" or "passed", never failed in the achievement controller display

axelm’s picture

axelm
Primary language English
commented

Hi @AaronBauman
Thanks, patch will be applied in the next release (but we renamed “step_state_passed“ to “lp_step_state_passed“, this wasn't correct in the patch that you suggested.

axelm’s picture

axelm
Primary language English
commented
Status: Needs review » Patch (to be ported)
axelm’s picture

axelm
Primary language English
commented
Status: Patch (to be ported) » Fixed

Releases in Opigno 2.27

axelm’s picture

axelm
Primary language English
commented
Status: Fixed » Closed (fixed)