Problem/Motivation

In #3044175: [DO NOT COMMIT] Vendor minimum testing issue it was discovered that some of our minimum dependencies are actually too low for all our tests to pass.

Steps to reproduce

See #3044175: [DO NOT COMMIT] Vendor minimum testing issue

Proposed resolution

Bump these dependencies to the minimum required for the tests to pass.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#2 3215280.patch3.55 KBlongwave

Comments

longwave created an issue. See original summary.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Active » Needs review
StatusFileSize
new 3215280.patch3.55 KB

We need minimums of :

  • Coder 8.3.10 for Drupal.Classes.UseGlobalClass sniff.
  • PHPUnit 8.5.14 for PhpUnitWarningsTest to pass.
  • Prophecy 1.12 to avoid three fatal errors in DateTimeNormalizerTest and friends and also run OptimizedPhpArrayDumperTest.
  • doctrine/annotations 1.12 to avoid a failure in DocParserTest.
  • MinkBrowserKitDriver 1.4 to avoid Symfony deprecations.
  • fabpot/goutte 3.3 to run GoutteDriverTest
  • instaclick/php-webdriver 1.4.1 to upload files in Selenium tests

composer-lock-diff of our original minimum dependencies vs the versions with this patch.

$ composer-lock-diff --no-links
+----------------------+--------+--------+
| Production Changes   | From   | To     |
+----------------------+--------+--------+
| doctrine/annotations | v1.4.0 | 1.12.0 |
+----------------------+--------+--------+

+-----------------------------------------+--------+---------+
| Dev Changes                             | From   | To      |
+-----------------------------------------+--------+---------+
| behat/mink-browserkit-driver            | 1.3.3  | REMOVED |
| dflydev/markdown                        | v1.0.0 | REMOVED |
| doctrine/instantiator                   | 1.2.0  | 1.3.1   |
| drupal/coder                            | 8.3.7  | 8.3.10  |
| fabpot/goutte                           | v3.2.2 | v3.3.0  |
| friends-of-behat/mink-browserkit-driver | v1.3.3 | v1.4.0  |
| instaclick/php-webdriver                | 1.1    | 1.4.1   |
| myclabs/deep-copy                       | 1.9.1  | 1.10.0  |
| phar-io/manifest                        | 1.0.3  | 2.0.1   |
| phar-io/version                         | 2.0.1  | 3.0.2   |
| phpdocumentor/reflection-docblock       | 2.0.0  | 5.2.0   |
| phpspec/prophecy                        | 1.8.1  | 1.12.0  |
| phpunit/php-code-coverage               | 7.0.7  | 7.0.12  |
| phpunit/php-token-stream                | 3.1.0  | 3.1.1   |
| phpunit/phpunit                         | 8.4.1  | 8.5.14  |
| sebastian/environment                   | 4.2.2  | 4.2.3   |
| sebastian/exporter                      | 3.1.1  | 3.1.2   |
| squizlabs/php_codesniffer               | 3.4.1  | 3.5.6   |
| phpdocumentor/reflection-common         | NEW    | 2.2.0   |
| phpdocumentor/type-resolver             | NEW    | 1.3.0   |
| sirbrillig/phpcs-variable-analysis      | NEW    | v2.8.0  |
| webmozart/assert                        | NEW    | 1.9.1   |
+-----------------------------------------+--------+---------+
effulgentsia’s picture

effulgentsia commented
Status: Needs review » Reviewed & tested by the community

Thank you! I agree that we should raise our minimums to reflect what we actually need for tests to pass. Since this doesn't make any changes to our pinned dependencies, and since all changes other than doctrine/annotations is just to dev dependencies, I'm RTBC'ing it.

If we're at a point in the 9.2.x cycle where we don't want to raise the minimum for doctrine/annotations, then we could potentially look into how to make DocParserTest pass with 1.4, but leaving this for a release manager to decide on that.

  • catch committed b1886b9 on 9.3.x 
    Issue #3215280 by longwave, effulgentsia: Bump minimum dependencies...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 9.3.x and cherry-picked to 9.2.x, thanks!

  • catch committed 126e125 on 9.2.x 
    Issue #3215280 by longwave, effulgentsia: Bump minimum dependencies...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.