Problem/Motivation

This is a follow-up issue of #3131281: Replace assertEqual() with assertEquals().
As assertEqual was deprecated and removed form core, the comments that refer to the test function must be removed as well.

Proposed resolution

Remove all comments related to assertEqual()

Issue fork drupal-3215143

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

paulocs created an issue. See original summary.

paulocs opened merge request !700

paulocs closed merge request !700

paulocs opened merge request !701

paulocs’s picture

paulocs
Primary language Portuguese, Brazil
Location Belo Horizonte
commented
Status: Active » Needs review
daffie’s picture

daffie commented
Status: Needs review » Needs work

The current MR changes over a 1000 files. There are not that many files with "assertEqual(" in a comment.

paulocs’s picture

paulocs
Primary language Portuguese, Brazil
Location Belo Horizonte
commented

Yeah. Consider merge request #701.
I had problems because the time between I clicked "create an issue fork" and pushed was short and the issue fork was not ready so I think that is why a lot files were added.

paulocs’s picture

paulocs
Primary language Portuguese, Brazil
Location Belo Horizonte
commented

I closed MR #700 so I don't know why tests are triggering in #700 and not in #701

daffie’s picture

daffie commented

Just one nitpick.

paulocs’s picture

paulocs
Primary language Portuguese, Brazil
Location Belo Horizonte
commented
Status: Needs work » Needs review
daffie’s picture

daffie commented
Status: Needs review » Reviewed & tested by the community

Looks good now.
For me it is RTBC.
The MR with ID = 701!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Title: Replace replace assertEqual( in some comments » Replace replace assertEqual() in some comments
Version: 9.3.x-dev » 9.2.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed 026280b8f2 to 9.3.x and 6202bbf42e to 9.2.x. Thanks!

Backported to 9.2.x as this is docs only fixes.

  • alexpott committed 026280b on 9.3.x 
    Issue #3215143 by paulocs, daffie: Replace replace assertEqual() in some...

  • alexpott committed 6202bbf on 9.2.x 
    Issue #3215143 by paulocs, daffie: Replace replace assertEqual() in some...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.