Problem/Motivation

getActiveMultiple() and getCanonicalMultiple() methods in EntityRepositoryInterface both returns arrays of EntityInterface but the returning type hinting miss the [] at the end.

Proposed resolution

Add [] after @return \Drupal\Core\Entity\EntityInterface on lines 117 and 163.

Release notes snippet

Fix return value type hinting for getActiveMultiple() and getCanonicalMultiple() in EntityRepositoryInterface.

CommentFileSizeAuthor
entity-repository-interface-doc.patch1.12 KBjmsosso

Comments

jmsosso created an issue. See original summary.

jmsosso’s picture

jmsosso commented
Issue tags: -Documentation
spokje’s picture

spokje
Primary language Dutch
commented
Version: 8.9.x-dev » 9.3.x-dev
Status: Active » Reviewed & tested by the community

Changed version to 9.3.x since changes land there and will be backported where "The Elders" (=Core committers) see fit.

Reviewed patch, changes in Type Hinting made sense to me => RTBC

catch’s picture

catch
he/him
Primary language English
commented
Version: 9.3.x-dev » 9.2.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 9.3.x and cherry-picked to 9.2.x, thanks!

  • catch committed cf221c0 on 9.3.x 
    Issue #3214773 by jmsosso, Spokje: Wrong type hint for getActiveMultiple...

  • catch committed 65ba770 on 9.2.x 
    Issue #3214773 by jmsosso, Spokje: Wrong type hint for getActiveMultiple...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.