Closed (fixed)
Project:
UI Examples
Version:
1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
19 May 2021 at 08:37 UTC
Updated:
30 Aug 2021 at 12:19 UTC
Jump to comment: Most recent
- composer.json is not needed as the module as no special dependencies.
- LICENSE.txt is added automatically by Drupal.org packaging system.
But, I see that the module is also on Github https://github.com/pdureau/ui_examples. So? Which repository is the canonical one?
PHPCS:
FILE: project/app/modules/custom/ui_examples/README.md
----------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
----------------------------------------------------------------------
6 | WARNING | Line exceeds 80 characters; contains 119 characters
15 | WARNING | Line exceeds 80 characters; contains 82 characters
----------------------------------------------------------------------
FILE: project/app/modules/custom/ui_examples/ui_examples.links.menu.yml
-----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------
5 | ERROR | [x] Expected 1 newline at end of file; 2 found
-----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------
FILE: project/app/modules/custom/ui_examples/src/ExamplePluginManagerInterface.php
----------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------
1 | ERROR | Missing required strict_types declaration
----------------------------------------------------------------------------------
FILE: project/app/modules/custom/ui_examples/ui_examples.module
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
1 | ERROR | Missing required strict_types declaration
----------------------------------------------------------------------
FILE: project/app/modules/custom/ui_examples/src/Controller/ExamplesLibraryController.php
-----------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
-----------------------------------------------------------------------------------------------------------------
1 | ERROR | Missing required strict_types declaration
13 | WARNING | The class short comment should describe what the class does and not simply repeat the class name
-----------------------------------------------------------------------------------------------------------------
FILE: project/app/modules/custom/ui_examples/src/ExamplePluginManager.php
------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
------------------------------------------------------------------------------------------------------------------------------
1 | ERROR | [ ] Missing required strict_types declaration
74 | WARNING | [x] 'TODO: Add validation of the plugin definition here.' should match the format '@todo Fix problem X here.'
------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------
PHPStan:
------ --------------------------------------------------------------------------------------------------------------------------
Line modules/custom/ui_examples/src/Controller/ExamplesLibraryController.php
------ --------------------------------------------------------------------------------------------------------------------------
33 Method Drupal\ui_examples\Controller\ExamplesLibraryController::create() has no return typehint specified.
56 Method Drupal\ui_examples\Controller\ExamplesLibraryController::single() has parameter $name with no typehint specified.
67 Method Drupal\ui_examples\Controller\ExamplesLibraryController::title() has parameter $name with no typehint specified.
------ --------------------------------------------------------------------------------------------------------------------------
------ ---------------------------------------------------------------------------------------------------------------------------
Line modules/custom/ui_examples/src/ExamplePluginManager.php
------ ---------------------------------------------------------------------------------------------------------------------------
17 Drupal\ui_examples\ExamplePluginManager must override __construct if using YAML plugins.
17 Plugin definitions cannot be altered.
72 Method Drupal\ui_examples\ExamplePluginManager::processDefinition() has no return typehint specified.
72 Method Drupal\ui_examples\ExamplePluginManager::processDefinition() has parameter $definition with no typehint specified.
72 Method Drupal\ui_examples\ExamplePluginManager::processDefinition() has parameter $plugin_id with no typehint specified.
83 Method Drupal\ui_examples\ExamplePluginManager::providerExists() has parameter $provider with no typehint specified.
------ ---------------------------------------------------------------------------------------------------------------------------
Also some typos and using single quotes instead of double quotes.
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
grimreaperAbout PHPStan
It is a bug in PHPStan Drupal: https://github.com/mglaman/phpstan-drupal/issues/142
Comment #4
grimreaperThere is only:
15 | WARNING | Line exceeds 80 characters; contains 82 charactersin README.md that I was not able to fix as it is a code example.
Comment #6
grimreaperMerged
Comment #7
grimreaperhttps://gitlab.com/florenttorregrosa-drupal/docker-drupal-project/-/jobs...
https://gitlab.com/florenttorregrosa-drupal/docker-drupal-project/-/jobs...
Comment #10
grimreaper