Problem/Motivation
We have used Rector and found Drupal 9 compatibility issues
Steps to reproduce
Proposed resolution
Submitting a patch
Rector Report
1) web/modules/contrib/group_purl/src/Context/GroupPurlContext.php
`
---------- begin diff ----------
--- Original
+++ New
@@ -87,9 +87,6 @@
return ['group' => $context];
}
- /**
- *
- */
public function getGroupFromRoute() {
if ($this->modifierMatched === NULL) {
return;
----------- end diff -----------
`
2) web/modules/contrib/group_purl/src/Plugin/Purl/Method/GroupSubdomain.php
`
---------- begin diff ----------
--- Original
+++ New
@@ -80,9 +80,6 @@
}
return strpos($uri, '/' . $modifier . '/') === 0;
}
- /**
- *
- */
public function alterRequest(Request $request, $identifier) {
// cannot use $request->uri as this sets it to the current server URI, making
// it too late to modify
@@ -99,9 +96,6 @@
return FALSE;
}
- /**
- *
- */
public function enterContext($modifier, $path, array &$options) {
// first fix up path...
if (isset($options['host'])) {
@@ -124,9 +118,6 @@
return $path;
}
- /**
- *
- */
public function exitContext($modifier, $path, array &$options) {
if (!$this->checkPath($modifier, $path)) {
return NULL;
----------- end diff -----------
`
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | 3214679-3.patch | 1.76 KB | deepaverma |
Issue fork group_purl-3214679
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
deepaverma commentedComment #3
deepaverma commentedD9 compatibility fixes in the patch
Comment #4
deepaverma commentedComment #5
deepaverma commentedComment #6
deepaverma commentedComment #9
avpadernoComment #12
freelockThanks for the contribution! Merged.