Problem/Motivation

We have used Rector and found Drupal 9 compatibility issues

Steps to reproduce

Proposed resolution

Submitting a patch

Rector Report

1) web/modules/contrib/group_purl/src/Context/GroupPurlContext.php
`
---------- begin diff ----------
--- Original
+++ New
@@ -87,9 +87,6 @@
return ['group' => $context];
}

- /**
- *
- */
public function getGroupFromRoute() {
if ($this->modifierMatched === NULL) {
return;
----------- end diff -----------
`

2) web/modules/contrib/group_purl/src/Plugin/Purl/Method/GroupSubdomain.php
`
---------- begin diff ----------
--- Original
+++ New
@@ -80,9 +80,6 @@
}
return strpos($uri, '/' . $modifier . '/') === 0;
}
- /**
- *
- */
public function alterRequest(Request $request, $identifier) {
// cannot use $request->uri as this sets it to the current server URI, making
// it too late to modify
@@ -99,9 +96,6 @@
return FALSE;
}

- /**
- *
- */
public function enterContext($modifier, $path, array &$options) {
// first fix up path...
if (isset($options['host'])) {
@@ -124,9 +118,6 @@
return $path;
}

- /**
- *
- */
public function exitContext($modifier, $path, array &$options) {
if (!$this->checkPath($modifier, $path)) {
return NULL;
----------- end diff -----------
`

Issue fork group_purl-3214679

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

deepaverma created an issue. See original summary.

deepaverma’s picture

Issue summary: View changes
deepaverma’s picture

StatusFileSize
new1.81 KB

D9 compatibility fixes in the patch

deepaverma’s picture

StatusFileSize
new1.83 KB
deepaverma’s picture

StatusFileSize
new1.76 KB
deepaverma’s picture

u_tiwari made their first commit to this issue’s fork.

avpaderno’s picture

Title: Drupal 9 Compatibility issues » Make the module compatible with Drupal 9
Version: 8.x-1.0-alpha2 » 8.x-1.x-dev
Status: Active » Needs review

freelock made their first commit to this issue’s fork.

  • freelock committed a439eac on 8.x-1.x authored by u_tiwari
    Issue #3214679 by u_tiwari, deepaverma, apaderno: Make the module...
freelock’s picture

Status: Needs review » Fixed

Thanks for the contribution! Merged.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.