Problem/Motivation
If you try to add a "Content Item" widget with a "Piece of content" referring to a node with a title longer than 128 characters, you'll get the following validation errors:
exposed cannot be longer than 128 characters but is currently 161 characters long.
title cannot be longer than 128 characters but is currently 161 characters long.
Steps to reproduce
- Add a Content Item widget
- Try to load a node content item with a longer title (longer than 128 characters)
- Notice that you can't save the widget due to the error
Proposed resolution
There's an upstream patch that seems to have the right idea: #1973580: Term reference filter autocomplete ('is one of', 'is none of') has a maximum length of 128 characters
However, it doesn't seem super likely that it'll be merged (that issue is already 8 years old, and the patch is 2 years old). We can use a form alter to fix it in panopoly_widgets.
Remaining tasks
- Write patch
- Review
- Merge!
User interface changes
None.
API changes
None.
Data model changes
None.
Comments
Comment #2
dsnopekPatch is attached, which fixes this in my testing!
Comment #3
cboyden commentedHere's a module-only reroll of the patch for anyone using panopoly_widgets outside the full Panopoly distribution.
Comment #4
cboyden commentedHere's a patch for testing this update.
Comment #5
cboyden commentedUpdated test patch to fix missing step.
Edited to add: Tests are generally passing, see https://travis-ci.org/github/cboyden/panopoly/builds/770833373
Comment #6
dsnopekLooks like the patch wasn't working in all situations. Here's a new version!
Comment #7
cboyden commentedThis is working fine on our child distribution.
Comment #9
dsnopekThanks! Committed :-)