Problem/Motivation

Some words don't work at all in the permissions filter and show no results at all even though it looks they should.

For example:

- 'Administer': no results, although many permissions begin with this word.
- 'Administer blocks': no results, but there is a permission with this name
- 'blocks': no results

My guess is that the filter is actually working on the *module* names on the form.

But it doesn't make that clear -- the filter just says 'Filter by name'.

There is a title on the filter form element, 'Filter modules', which actually explains it, but it's set to invisible!

CommentFileSizeAuthor
#6 Screenshot from 2021-07-22 11-41-57.png61.68 KBmarcusvsouza
#4 3212569-4.patch532 bytespaulocs

Issue fork module_filter-3212569

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

joachim created an issue. See original summary.

greenskin’s picture

greenskin commented

Thanks for the observation. Yeah, the idea was the module has a focus on filtering "modules". There is a feature that allows filtering by permission string (perm:"permission string") which been meaning to provide documentation for. The page's filter could definitely use some UX work.

joachim’s picture

joachim commented

A very simple fix would be to change the UI text on the filter -- change 'Filter by name' to 'Filter by module' and then it's clear.

paulocs’s picture

paulocs
Primary language Portuguese, Brazil
Location Belo Horizonte
commented
Priority: Major » Normal
StatusFileSize
new 3212569-4.patch532 bytes

I created a patch for it. I agree that the field placeholder must be changed.

paulocs’s picture

paulocs
Primary language Portuguese, Brazil
Location Belo Horizonte
commented
Status: Active » Needs review
marcusvsouza’s picture

marcusvsouza commented
StatusFileSize
new Screenshot from 2021-07-22 11-41-57.png61.68 KB

The patch in the comment #4 correctly changes the placeholder name.

smustgrave made their first commit to this issue’s fork.

smustgrave opened merge request !8

  • smustgrave committed daae5d2d on 8.x-3.x 
    Issue #3212569: Permissions filter appears to filter on module name, but...
smustgrave’s picture

smustgrave commented
Status: Needs review » Fixed

Thanks for the fix!

jonathan1055’s picture

jonathan1055 commented
Issue summary: View changes

Good to have the text label changed.

It would be nice to be able to filter by module name or module description, because the description is what you can immediately read on the page. That also gives admins and developers a quicker and alternative way to get to the modules they want. Maybe it should be a separate follow-up issue.

joachim’s picture

joachim commented

> It would be nice to be able to filter by module name or module description

Yes, definitely. I figured fix the current UI first, as UI text is quicker to get fixed than new functionality.

Please make a follow-up :)

jonathan1055’s picture

jonathan1055 commented

I have opened the follow-up #3327899: Filter on module description (module_filter)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

jonathan1055’s picture

jonathan1055 commented

I have also created #3331723: Filter permissions on description not just module name for the permission description