Problem/Motivation

Connection::queryTemporary() is not used anywhere in Core, and has very limited usage in contrib (most are db driver implementations).

Implementing it in db drivers is not straightforward, either - for instance in SQLite it is necessary to tamper with the table prefix array, and we are trying to remove table-level prefixes in other issues. Oracle 11 does not have session-level temporary tables, so workarounds are needed.

Proposed resolution

Deprecate Connection::queryTemporary() for removal in Drupal10.

Remaining tasks

None

User interface changes

None

API changes

The method Drupal\Core\Database\Connection::queryTemporary() and the internal method Drupal\Core\Database\Connection::generateTemporaryTableName() are deprecated.

Data model changes

None

Release notes snippet

None

Issue fork drupal-3211780

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mondrake created an issue. See original summary.

mondrake opened merge request !616

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Active » Needs review

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

daffie’s picture

daffie commented
Related issues: +#3106531: Notify in Status Report that per-table database prefixes are no longer supported, and will throw errors in Drupal 10.0

The issue #3106531: Notify in Status Report that per-table database prefixes are no longer supported, and will throw errors in Drupal 10.0 is blocked on this issue.

daffie’s picture

daffie commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

I agree with you @mondrake. Lets deprecate this functionality.

The method Drupal\Core\Database\Connection::generateTemporaryTableName() is a protected method, therefore it is considered as internal and not part of the public API. It does not have to be deprecated. Only it is used by contrib database drivers. Maybe better to do the deprecation and keep the change.

I have updated the CR and the IS.
It all looks good to me.
For me it is RTBC.

mondrake’s picture

mondrake
Location 🇮🇹
commented

Thanks for CR and IS updates, @daffie

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Makes sense to deprecate this in its own right, as well as unblocking per-table prefixes.

Committed 32f7a69 and pushed to 9.3.x. Thanks!

  • catch committed a35df16 on 9.3.x 
    Issue #3211780 by mondrake, daffie: Deprecate Connection::queryTemporary...

mondrake closed merge request !616

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

japerry’s picture

japerry
Location KOMK
commented

For those who may land on this issue -- It was reverted in Drupal 9.4.x and 10.0.x See https://www.drupal.org/project/drupal/issues/3312641