Adjust Database API to remove deprecated Drupal 9 code in Drupal 10

I would suggest to rescope this issue to adjusting ALL the Database API for D10, it will be difficult to separate removing just the magic methods from the rest.

This is more or less doing the job, with current HEAD. Posting so to help future efforts.

Hey @mondrake, I updated the PR, I think during the rebase, an use statement was removed from the ConnectionTest.php, looking into the failed tests, I haven't seen anything related to the StatementInterface, that's why I decided to rollback this part of the code.

Now the only failed test should be the testComposerLockHash, but I think this is an expected fail because you've changed the composer.lock, I just don't how to make it pass again.

Anyway, if I did something wrong, please let me know.

Thanks!

That's a good catch @andypost, unfortunately I don't have access to change the MR target branch, maybe @mondrake could.

I am waiting for #3129043: Move core database drivers to modules of their own, honestly.

I think this is Needs work as the MR needs a rebase / merge.

My first review. I will do another when I have more time.

Thanks for review @daffie!

WRT type hinting, it's a BC change, it's a broader topic than this issue, new code should be typehinted but I do not see clarity on how to proceed on existing one yet. #3050720: [Meta] Implement strict typing in existing code is still open. So.. not here.

There are unresolved thread on the MR.

We need a CR for the deprecation of db_installer_object().

I have create the CR.
There are 4 unresolved threads on the MR.

Thanks @daffie

I can see why you've deprecated db_installer_object() here but I think that this needs it's own issue. I think we should refactor the code here to always call it with $namespace and not be too particular about what goes in $driver. And then we should open and issue to deprecate in Drupal 9.4 for Drupal 11.

Thanks, reverted that deprecation and rerolled.

Filed #3256687: Deprecate db_installer_object() for follow up, although deprecation can only occur in 10 likely, since in 9.4. there may still be around contrib db drivers in the legacy namespace.

Reverted all changes to include.inc - those can be addressed separately and the MR now should be deprecation removals only.

The MR looks good.
The points of @alexpott have been addressed.
For me it is RTBC.

Committed 8f2269d and pushed to 10.0.x. Thanks!

 34 files changed, 106 insertions(+), 1689 deletions(-)

That is a lovely diff stat :)

diff --git a/core/tests/Drupal/KernelTests/Core/Cache/EndOfTransactionQueriesTest.php b/core/tests/Drupal/KernelTests/Core/Cache/EndOfTransactio
nQueriesTest.php
index 1d735d511de..6f4175e7412 100644
--- a/core/tests/Drupal/KernelTests/Core/Cache/EndOfTransactionQueriesTest.php
+++ b/core/tests/Drupal/KernelTests/Core/Cache/EndOfTransactionQueriesTest.php
@@ -184,7 +184,7 @@ protected function getDatabaseConnectionInfo() {
     // @see \Drupal\database_statement_monitoring_test\mysql\Connection
     // @see \Drupal\database_statement_monitoring_test\pgsql\Connection
     // @see \Drupal\database_statement_monitoring_test\sqlite\Connection
-    $info['default']['namespace'] = '\Drupal\database_statement_monitoring_test\\' . $info['default']['driver'];
+    $info['default']['namespace'] = 'Drupal\database_statement_monitoring_test\\' . $info['default']['driver'];
     return $info;
   }

This change is not necessary. So reverting it on commit. If it is necessary for the db_installer_object changes then we can do this there.