Related to comment https://www.drupal.org/project/uswds_base/issues/3204187#comment-14068414
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | with-patch.png | 379.53 KB | leraa |
| #8 | without-patch.png | 339.31 KB | leraa |
| #8 | add-class.png | 65.82 KB | leraa |
Issue fork uswds_base-3210099
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #3
smustgrave commentedComment #5
mferanda commentedGood catch @leraa... since you discovered, can you test this patch and let us know?
If you're able, snip showing the class you tried to apply and it actually showing in the html.
Thank you for your help
Comment #6
leraa commented@mferanda,
You know, I actually wasn't applying a class, I was applying the target attribute. During testing is when I noticed that the typo change my link classes. I fixed the typo to restore original classes being put on by USWDS.
I'm happy to test, but I don't have anything to show for the class thing. Do you want to see the attribute working properly? And how do you like seeing stuff? Screenshots? Scraping code?
I could also temporarily apply a class just for show-and-tell if that seems helpful.
Let me know what's best to help out and what format is best.
Comment #7
mferanda commented@leraa yeah! Just add some type of dummy class. Maybe a snip showing it not working in the source. Apply the patch and show after with it working. (Before/after proof of working)
Comment #8
leraa commentedOk, using the Menu Link Attributes module, I added a class to a menu link:
WIthout the patch, the template does add my new class, but it removes the other class that's supposed to be put there by USWDS, and instead puts
class="test-my-new-class item_classes"After the patch removes the ticks, the correct USWDS-assigned
class="test-my-new-class usa-nav__link"that is set inside the template at around line 107 appears:Comment #9
leraa commentedI should add my organization in this contribution.
Comment #10
mferanda commented@leraa - Add whatever you want right now before I finalize everything.
Thank you for your contribution to this issue.
Comment #11
mferanda commentedNevermind! I see... finalizing everything. Thanks again.
Comment #13
mferanda commentedComment #14
mferanda commentedAdded and pushed out the typo fix as 2.10-rc2...
If anyone would like to help me test rc2 for a thumbs up, please do so on this other thread.
https://www.drupal.org/project/uswds_base/issues/3179547
I'll push out this 2.10 as stable so we move on to the 2.11 changes with some new features.
Thank you!
Comment #15
mferanda commentedComment #16
mferanda commented