Problem/Motivation

If there are a decently large number of Storage entities, the admin permissions page runs out of memory, resulting in a WSOD.

I'm guessing this module was scaffolded using Drupal Console, and that this is an occurrence of this bug:
https://github.com/hechoendrupal/drupal-console/issues/4225

Steps to reproduce

Generate 5000 storage entities, then visit the /admin/people/permissions page

Proposed resolution

Replace uses of the Storage class with StorageType.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#2 storage-3209386-permissions.patch1.15 KBles lim

Comments

Les Lim created an issue. See original summary.

les lim’s picture

les lim
he/they
Primary language English
commented
Status: Active » Needs review
StatusFileSize
new storage-3209386-permissions.patch1.15 KB

Patch attached.

  • mandclu committed 68a11e1 on 1.0.x authored by Les Lim 
    Issue #3209386 by Les Lim: Out of memory errors on Permissions page
mandclu’s picture

mandclu commented
Status: Needs review » Fixed

Great catch! Thanks for identifying this, and for providing a fix. Merged in.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

andileco’s picture

andileco commented

Thanks for fixing this issue, but please create a new release, too!

mandclu’s picture

mandclu commented

@andileco I was thinking about making a stable release once I merge #3209333: Missing "Create new revision" option on storage edit form. Could I interest you in helping with the testing of that?