The Block plugin view builder module allows developers to programmatically render (view) block plugins without the need for the wrapping BlockContent entity.

Project link

https://www.drupal.org/project/block_plugin_view_builder

Git instructions

git clone https://git.drupalcode.org/project/block_plugin_view_builder.git

PAReview checklist

https://pareview.net/r/164

Comments

wtrv created an issue. See original summary.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Title: [D8][D9] - Block plugin view builder » [D9] Block plugin view builder
Issue summary: View changes
nils.destoop’s picture

nils.destoop commented
Status: Needs review » Needs work

Code seems ok. There are only some small coding standard fixes left:

FILE: block_plugin_view_builder/README.md
---------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
---------------------------------------------------------------------------------------------------------------------
10 | WARNING | Line exceeds 80 characters; contains 240 characters
14 | WARNING | Line exceeds 80 characters; contains 81 characters
18 | WARNING | Line exceeds 80 characters; contains 155 characters
---------------------------------------------------------------------------------------------------------------------

FILE: block_plugin_view_builder/src/BlockPluginViewBuilder.php
------------------------------------------------------------------------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
------------------------------------------------------------------------------------------------------------------------------------------
172 | ERROR | [x] Data types in @var tags need to be fully namespaced
208 | ERROR | [ ] Parameter $configuration is not described in comment
225 | ERROR | [ ] Parameter $moduleHandler is not described in comment
230 | ERROR | [ ] Doc comment for parameter $module_handler does not match actual variable name $moduleHandler
---------------------------------------------------------------------------------------------------------------------------

You can also remove the 'core: 8.x' in your info file. It's not needed anymore.

wtrv’s picture

wtrv commented

Thanks for the review.

Coding standards have been fixed.
I also introduced a new interface and added a new "viewPlugin" method in the block builder service.

wtrv’s picture

wtrv commented
Status: Needs work » Needs review
nils.destoop’s picture

nils.destoop commented
Status: Needs review » Reviewed & tested by the community

Ok for me now

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Reviewed & tested by the community » Fixed

manual review:
If you depend on PHP 7.4 you should add that to the info.yml file.

Otherwise looks good to me!

Thanks for your contribution, wtrv!

I updated your account so you can opt into security advisory coverage now.

Here are some recommended readings to help with excellent maintainership:

You can find lots more contributors chatting on Slack or IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.