Closed (fixed)
Project:
Character Count Formatter
Version:
1.0.x-dev
Component:
Code
Priority:
Minor
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
12 Apr 2021 at 22:25 UTC
Updated:
5 May 2021 at 04:59 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
hotwebmatter commentedComment #3
lhockleyOh hey. Thanks for your contribution!
I am not too familiar with implementing patch updates. I believe that is sorta considered the "old way"?
Would it be possible for you to make these changes in an issue branch and open a merge request for my review?
Comment #6
hotwebmatter commentedI took a minute to make a Merge Request: https://git.drupalcode.org/project/charcount/-/merge_requests/1
You can ignore the patch I made in your issue queue.
Comment #7
lhockleyAll the changes look reasonable. I just want to learn a little more about the changes to use ConfigFactoryInterface vs ConfigFactory. Again, really appreciate your contribution here.
Comment #8
hotwebmatter commentedFrom the Drupal API docs:
For comparison, see this service implementation of the
DiffFormatterclass in Drupal core:Your
$config_factoryneeds to implement theConfigFactoryInterfacebecause it is a factory class.Comment #9
lhockleyThank you for the contribution, and the clarification on changes.