Problem/Motivation

The keyboard shortcut CTRL + K is already in use by Core's Drupal Link (you can see it on core/modules/ckeditor/js/plugins/drupallink/plugin.js), so ideally we should set a different keystroke for the tooltip.

Proposed resolution

Change the keystroke to another letter, I've added as a suggestion the letter L.

Remaining tasks

Define if L is the best key for this shortcut.

CommentFileSizeAuthor
#6 ckeditor-keystroke-shortcut_3208458-6.patch609 bytesbbombachini
#5 ckeditor-keystroke-shortcut-3208458-5.patch615 bytesbbombachini
#2 ckeditor-keystroke-shortcut-3208458-2.patch435 bytesbbombachini

Comments

bbombachini created an issue. See original summary.

bbombachini’s picture

bbombachini
Location London, ON
commented
StatusFileSize
new ckeditor-keystroke-shortcut-3208458-2.patch435 bytes
bbombachini’s picture

bbombachini
Location London, ON
commented
Issue summary: View changes
bbombachini’s picture

bbombachini
Location London, ON
commented
Status: Active » Needs review
bbombachini’s picture

bbombachini
Location London, ON
commented
StatusFileSize
new ckeditor-keystroke-shortcut-3208458-5.patch615 bytes

After a while I've realized that core's link plugin uses Ctrl+K or Ctrl+L so in order to avoid further conflicts I'd suggest Shift+T.
Here's a new patch.

bbombachini’s picture

bbombachini
Location London, ON
commented
StatusFileSize
new ckeditor-keystroke-shortcut_3208458-6.patch609 bytes

Silly of me because then editors are not able to add capital T letters so I'm adding another patch to update the shortcut to ALT+T instead.

  • bbombachini authored b945250 on 4.x 
    Issue #3208458 by bbombachini: Ckeditor key stroke already in use by...
bbombachini’s picture

bbombachini
Location London, ON
commented
Version: 8.x-3.0 » 4.0.0
Status: Needs review » Fixed
bbombachini’s picture

bbombachini
Location London, ON
commented
Status: Fixed » Closed (fixed)