Problem/Motivation
/**
* ScaffoldFilePath constructor.
*
* @param string $path_type
* The type of scaffold file this is, 'src' or 'dest'.
* @param string $package_name
* The name of the package containing the file.
* @param string $rel_path
* The relative path to the file.
* @param string $full_path
* The full path to the file.
*/
public function __construct($path_type, $package_name, $rel_path, $full_path) {
but:
return new ScaffoldFilePath('autoload', $package_name, $dest_rel_path, $dest_full_path);
ScaffoldFilePath should document that 'autoload' is allowed as well.
Steps to reproduce
Proposed resolution
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
Comments
Comment #3
guilhermevp commentedShould
'autoload'be documented as'(optional)'?Comment #4
joachim commentedNo, the thing here is that the $path_type parameter is documented as only accepting one of 'src' or 'dest', but that's not true, as 'autoload' is also a possible value.
Comment #5
guilhermevp commentedComment #7
guilhermevp commentedThanks @joachim!
Created MR, please review!
Comment #8
joachim commentedLooks good, thanks!
Comment #9
alexpottComment #10
alexpottThis needs fixing too...
Comment #11
swatichouhan012 commentedCreated PR with include fixes of #10, please review.
Comment #12
guilhermevp commentedThanks @swatichouhan012! Patch now complies with #10 request. Moving to RTBC.
Comment #13
guilhermevp commentedComment #14
alexpottCommitted and pushed dc9a09e802 to 9.3.x and 4a445e8290 to 9.2.x. Thanks!