Problem/Motivation

Based on the recommendation in the additional notes in the README.md i've tried to enable published and authored by in the manage form display.

Steps to reproduce

1. Go to manage form display
2. drag published and authored by to the enabled state and save.
3a) Add a storage entity
3b) Take a look at an already existing storage entity

in both cases the checkbox is not showing and only the published by information is shown.

p.s. I am using alpha1 but with the two patches from the other two issues i've reported applied. so not tested with alpha1 exactly. that as a disclaimer. ;)

Comments

rkoller created an issue. See original summary.

rkoller’s picture

Title: If published is enabled in manage form display for a storage type it isn't showing for storage entites » If "published" is enabled in manage form display for a storage type it isn't showing for storage entities
mandclu’s picture

The attached patch should allow the publish field to be configured, and also changes the description to be a little more intuitive.

mandclu’s picture

Status: Active » Needs review
rkoller’s picture

Status: Needs review » Needs work

thanks for the fast patch! the publish form is showing now properly!

but one remark about the label description. on content types you don't have any. it is ok that you've introduced one. but one thing i consider confusing and or inconsistent is that the label description is differing between check box/radio buttons and single on/off checkbox. the former has the label description A boolean indicating whether the Storage is published. the latter Whether or not this diagramme is published.. cuz basically the on/off checkbox is a boolean as well. and in regards of the checkbox/radio button is the question what means N/A - and published on/off it would be more appropriate to use yes and no in that regard (that would be an issue for the general micro copy on content types as well). Maybe the easier approach would be to keep things consistent with content types and leave the label description out? what do you think?

mandclu’s picture

StatusFileSize
new1.24 KB

Eliminating the description altogether is a good call, and even easier. Updated patch attached.

mandclu’s picture

Status: Needs work » Needs review
StatusFileSize
new1.01 KB

Just realized that I was unnecessarily loading a class from core, removed that too.

rkoller’s picture

Status: Needs review » Reviewed & tested by the community

haha while i was entering my reply you've already updated the issue and patch another time :D also tested patch number 7 now and everything still works as expected. thanks for the quick fix! without the label description it is definitely cleaner and easier to comprehend :)

  • mandclu authored d836334 on 1.0.x
    Issue #3207065 by mandclu, rkoller: If "published" is enabled in manage...
mandclu’s picture

Status: Reviewed & tested by the community » Fixed

And thank you for the quick feedback! Merged in.

I'll probably give it another day or two in case you find any other issues, and then roll a new release.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.