Problem/Motivation

This issue is to add documentation for the following source plugins:

  • ContentEntity.php
  • d8/Config.php
  • EmbeddedDataSource.php
  • EmptySource.php

Proposed resolution

Do it.

Remaining tasks

Review, commit.

Issue fork drupal-3206939

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Matroskeen created an issue. See original summary.

Matroskeen opened merge request !491

matroskeen’s picture

matroskeen
Primary language Ukrainian
Location 🇺🇦 Ukraine, Lutsk
commented
Status: Active » Needs review

I have no idea what to add in ContentEntityDeriver.php yet. Please let me know if you have any suggestions.

quietone’s picture

quietone commented
Status: Needs review » Needs work

I have no idea what to add in ContentEntityDeriver.php yet.

Good question.
Searching shows there are 6 derivers in migrateland and I don't think any of them are documented. At least, D7NodeDeriver and D7TaxonomyTermDeriver are not. But what to do? Well, since there are only 6 and they all do much the same thing it would be efficient to add the documentation for them in one issue. What do you think?

Setting NW for unresolved comments.

quietone’s picture

quietone commented

@Matroskeen, what do you think of including the migrate module source plugins in this issue?

matroskeen’s picture

matroskeen
Primary language Ukrainian
Location 🇺🇦 Ukraine, Lutsk
commented
Title: Add documentation for Migrate Drupal source plugins » Add documentation for Migrate and Migrate Drupal source plugins
Issue summary: View changes
Status: Needs work » Needs review

It sounds good to me!
I didn't include DummyQueryTrait.php mentioned in the meta task because it looks good and I'm not sure what can be improved.

quietone’s picture

quietone commented
Status: Needs review » Reviewed & tested by the community

Glad you agree about doing both migrate and migrate_drupal plugins in one issue! Saves us all a bit of work.

I applied the diff locally and read through all the changes. It all looks good and all issue resolved. I agree about DummyQueryTrait, I too could not improve on what is there. It is sufficient to explain what it does.

The failing test is #3207086: [HEAD BROKEN] Consistent failure in MonthDatePluginTest which has been fixed so this can be RTBC.

  • catch committed 13932c1 on 9.2.x 
    Issue #3206939 by Matroskeen, quietone: Add documentation for Migrate...

  • catch committed 5d949a3 on 9.1.x 
    Issue #3206939 by Matroskeen, quietone: Add documentation for Migrate...
catch’s picture

catch
he/him
Primary language English
commented
Version: 9.2.x-dev » 9.1.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 9.2.x and cherry-picked to 9.1.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Matroskeen closed merge request !491