Problem/Motivation

The module does not work with Drupal 9

Steps to reproduce

Attempt to install the module on a D9 site

Proposed resolution

Update the code to make this compatible. I have already tested it and the migration works perfectly; so I think it's just a case of updating the info.yml file to be D9 compatible

Remaining tasks

* Review patch
* We probably also need a composer.json file for those who want to install the module using composer?

User interface changes

N/A

API changes

N/A

Data model changes

N/A

Patch to follow...

CommentFileSizeAuthor
#6 Drupal9_entity_settings.png349.36 KBsrishtiiee
#6 Drupal9_queue_settings.png275.96 KBsrishtiiee
#6 Drupal7_queue_settings.png469.38 KBsrishtiiee
#6 Drupal9_queue_content.png110.17 KBsrishtiiee
#6 Drupal7_queue_content.png235.43 KBsrishtiiee
#5 interdiff_4-5.txt1.25 KBsrishtiiee
#5 nodequeue_migrate-d9_compatible-3206490-5.patch1.25 KBsrishtiiee
#4 interdiff_2-4.txt332 bytessuresh prabhu parkala
#4 3206490-4.patch364 bytessuresh prabhu parkala
#2 nodequeue_migrate-d9_compatible-3206490-02.patch378 bytesmarc.groth

Comments

marc.groth created an issue. See original summary.

marc.groth’s picture

marc.groth commented
StatusFileSize
new nodequeue_migrate-d9_compatible-3206490-02.patch378 bytes

Please find attached patch that updates info.yml so that the module can be installed on D9.

marc.groth’s picture

marc.groth commented
Status: Active » Needs review
suresh prabhu parkala’s picture

suresh prabhu parkala commented
StatusFileSize
new 3206490-4.patch364 bytes
new interdiff_2-4.txt332 bytes

We have to keep the 'core: 8.x' key to make sure the module is compatible with drupal <8.7

srishtiiee’s picture

srishtiiee commented
StatusFileSize
new nodequeue_migrate-d9_compatible-3206490-5.patch1.25 KB
new interdiff_4-5.txt1.25 KB

Added migration tags and dependencies.

srishtiiee’s picture

srishtiiee commented
StatusFileSize
new Drupal7_queue_content.png235.43 KB
new Drupal9_queue_content.png110.17 KB
new Drupal7_queue_settings.png469.38 KB
new Drupal9_queue_settings.png275.96 KB
new Drupal9_entity_settings.png349.36 KB

Tested the migration manually, and it works fine.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs review » Reviewed & tested by the community 
  1. --- a/migration_templates/d7_nodequeue.yml
+++ b/migration_templates/d7_nodequeue.yml
@@ -2,6 +2,7 @@ id: d7_nodequeue
 label: Node queue
 migration_tags:
   - Drupal 7
+  - Configuration

@@ -21,3 +22,6 @@ process:
   plugin: entity:entity_queue

    EnitityQueue is a config entity 👍 

  2. +++ b/migration_templates/d7_nodequeue.yml
@@ -21,3 +22,6 @@ process:
+migration_dependencies:
+  required:
+    - d7_node_type

    Every node queue is configured to allow nodes of a certain type to be put in them, so the NodeType config entities already need to be migrated, and this dependency ensures that 👍 

  3. +++ b/migration_templates/d7_nodesubqueue.yml
@@ -2,6 +2,7 @@ id: d7_nodesubqueue
 label: Node subqueue
 migration_tags:
   - Drupal 7
+  - Content

    Subqueues are content entities 👍 

  4. +++ b/nodequeue_migrate.info.yml
@@ -3,7 +3,6 @@ type: module
-core: 8.x
 core_version_requirement: ^8.8 || ^9

    +1, otherwise the module is not installable in D9.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

Pinged the module maintainer @jofitz on Twitter: https://twitter.com/wimleers/status/1445289133350469632

Because until this is fixed, people won't be able to use this awesome module to migrate from nodequeue in D7 to entityqueue in D9!

  • c0af32d committed on 8.x-1.x 
    Issue #3206490 by marc.groth, srishti.bankar: Make the module D9...
jofitz’s picture

jofitz
he/him
commented
Status: Reviewed & tested by the community » Fixed
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

Thanks, @jofitz!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.