first of all, thank you very much fort this wonderfull module !!

Problem/Motivation

The "Settings" button uses the "settings" core translation.
When we change this translation, it changes the translation on the settings tab on all modules.
Would it be possible to use another text like the "Cookie Settings" one ?

Comments

sgilabert created an issue. See original summary.

sgilabert’s picture

Issue summary: View changes
sgilabert’s picture

Issue summary: View changes
sgilabert’s picture

Issue summary: View changes
jfeltkamp’s picture

Yes, you are right. I think about another word. Shold be one short word and intuitiv.

"Customize" (?)

Any other ideas?

sgilabert’s picture

"Customize" already exists too !
Maybe something like "Customize cookies"
Thanks !

corn696’s picture

It is possible to translate same words differently, if you provide a context in the translation function.

jfeltkamp’s picture

Version: 1.0.8 » 1.0.10

@Corn696: Thank you for the tip with the context. But it is a config translation and I can't make out, where I could give the module context for that.

@sgilabert: I had a look to the issue today, but I can't find the place where the "Settings" translation is used.
Can you (or someone else) give an example, where the translation was used for false.

  • JFeltkamp committed f8c5c34 on 1.0.x
    Issue #3206197: Change text on "settings" button
    
jfeltkamp’s picture

Status: Active » Needs review

It's very confusing, but now I think it's resolved. I don't really understand the interaction between the UI translation interface and the config translation. Anyway, now I've changed the translation origin string to "Cookie settings" and there shouldn't be any more problems. I think I should set up an update hook to transfer the translations of the module users.

Fixed in 1.0.x and will be included >= 1.0.11

anybody’s picture

Status: Needs review » Fixed

@sgilabert: Is this fixed for you now? I'll set this fixed for now, feel free to reopen otherwise.

@JFeltkamp: Context is only available for localization as far as I know and would be a further parameter to the translate function. I had a quick look into your code and think you're not using the translate function but config translation for everything? Or did I oversee a t() call?

For "static" UI texts typically localization would be used, but as you're doing things in JS mainly, you're using a different logic. I read some issues about strange relations between config translation and localization so I think you were running into an edge case which has flaws in Core.

anybody’s picture

@JFeltkamp: For reference, if you'd like to read complicated stuff;) #2905295: Configuration language being overwritten during module install + related issues

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.