Closed (fixed)
Project:
COOKiES Consent Management
Version:
1.0.10
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
29 Mar 2021 at 12:31 UTC
Updated:
1 Jul 2021 at 06:09 UTC
Jump to comment: Most recent
Comments
Comment #2
sgilabert commentedComment #3
sgilabert commentedComment #4
sgilabert commentedComment #5
jfeltkampYes, you are right. I think about another word. Shold be one short word and intuitiv.
"Customize" (?)
Any other ideas?
Comment #6
sgilabert commented"Customize" already exists too !
Maybe something like "Customize cookies"
Thanks !
Comment #7
corn696It is possible to translate same words differently, if you provide a context in the translation function.
Comment #8
jfeltkamp@Corn696: Thank you for the tip with the context. But it is a config translation and I can't make out, where I could give the module context for that.
@sgilabert: I had a look to the issue today, but I can't find the place where the "Settings" translation is used.
Can you (or someone else) give an example, where the translation was used for false.
Comment #10
jfeltkampIt's very confusing, but now I think it's resolved. I don't really understand the interaction between the UI translation interface and the config translation. Anyway, now I've changed the translation origin string to "Cookie settings" and there shouldn't be any more problems. I think I should set up an update hook to transfer the translations of the module users.
Fixed in 1.0.x and will be included >= 1.0.11
Comment #11
anybody@sgilabert: Is this fixed for you now? I'll set this fixed for now, feel free to reopen otherwise.
@JFeltkamp: Context is only available for localization as far as I know and would be a further parameter to the translate function. I had a quick look into your code and think you're not using the translate function but config translation for everything? Or did I oversee a t() call?
For "static" UI texts typically localization would be used, but as you're doing things in JS mainly, you're using a different logic. I read some issues about strange relations between config translation and localization so I think you were running into an edge case which has flaws in Core.
Comment #12
anybody@JFeltkamp: For reference, if you'd like to read complicated stuff;) #2905295: Configuration language being overwritten during module install + related issues