can not apply patch for email_confirmer [#3204804]

composer install
Gathering patches for root package.
> DrupalProject\composer\ScriptHandler::checkComposerVersion
Installing dependencies from lock file (including require-dev)
Verifying lock file contents can be installed on current platform.
Package operations: 1 install, 0 updates, 0 removals
- Syncing drupal/email_confirmer (dev-1.x 511a8e2) into cache
Gathering patches for root package.
Gathering patches for dependencies. This might take a minute.
- Installing drupal/email_confirmer (dev-1.x 511a8e2): Cloning 511a8e2949 from cache
- Applying patches for drupal/email_confirmer
https://www.drupal.org/files/issues/2019-06-13/email_confirmer-support_f... (Support for HTML mails (13063328))
Could not apply patch! Skipping. The error was: Cannot apply patch https://www.drupal.org/files/issues/2019-06-13/email_confirmer-support_f...

Package container-interop/container-interop is abandoned, you should avoid using it. Use psr/container instead.
Package drush/config-extra is abandoned, you should avoid using it. No replacement was suggested.
Generating autoload files
> DrupalProject\composer\ScriptHandler::createRequiredFiles

Issue fork webform_double_opt_in-3204804

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

8.x-1.x changes, plain diff MR !1
Check out this branch for the first time

Check out existing branch, if you already have it locally
3204804-can-not-apply compare
Check out this branch for the first time

Check out existing branch, if you already have it locally

About issue forks

Comments

Comment #1

21 March 2021 at 23:47

zuernBernhard created an issue. See original summary.

Comment #2

luksak

he/him

commented 22 April 2021 at 14:56

I have the same issue. It would be a lot easier to apply the patch manually since there is a re-rolled version of the patch.

Comment #3

luksak

he/him

commented 22 April 2021 at 15:22

I get messages like this when running composer update -vvv:

Executing command (CWD): patch '-p2' --no-backup-if-mismatch -d 'web/modules/contrib/email_confirmer' < '/tmp/6081935765cb9.patch'
can't find file to patch at input line 6
Perhaps you used the wrong -p or --strip option?

And requiring a different version of email_confirmer doesn't work either, because this module requires a specific commit hash... We should change the approach of this module handling this dependency.

My suggestion:

Require email_confirmer without a commit hash
Have users apply the patch on their own

Comment #4

22 April 2021 at 15:24

Lukas von Blarer opened merge request !1

Comment #5

luksak

he/him

commented 22 April 2021 at 15:35

Ok, i ran out of ideas how to fix this issue. Nothing like this works:

"extra": {
        "patches": {
            "drupal/webform_double_opt_in": {
                "#3204804: can not apply patch for email_confirmer": "https://git.drupalcode.org/project/webform_double_opt_in/-/merge_requests/1.patch"
            },
            "drupal/email_confirmer": {
                "Support for HTML mails (13063328)": "https://www.drupal.org/files/issues/2020-09-02/email_confirmer-implement_message_entity-3047124-30.patch"
            }
        },
        "patches-ignore": {
            "drupal/webform_double_opt_in": {
                "drupal/email_confirmer": {
                    "Support for HTML mails (13063328)": "https://www.drupal.org/files/issues/2019-06-13/email_confirmer-support_for_html_mails-3047124-16.patch"
                }
            }
        }
    }

If i am not mistaking, I was able to install it using composer 1 somehow....

It would be great to get this fixed asap.