CommentFileSizeAuthor
#4 Screenshot 2021-03-19 at 5.25.19 PM.png20.58 KBpradeepjha
#4 3204509-4.patch418 bytespradeepjha

Issue fork external_link_popup-3204509

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

dewalt created an issue. See original summary.

dewalt’s picture

dewalt commented
Issue summary: View changes
pradeepjha’s picture

pradeepjha commented
Assigned: Unassigned » pradeepjha
pradeepjha’s picture

pradeepjha commented
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new 3204509-4.patch418 bytes
new Screenshot 2021-03-19 at 5.25.19 PM.png20.58 KB
pradeepjha’s picture

pradeepjha commented
Issue summary: View changes

There is condition written inside code base. If there is no title then hide title bar. That's why it's hiding close button as well.
After applying patch, even though if there is no title, title bar will be visible along with close icon.

pradeepjha’s picture

pradeepjha commented
Assigned: pradeepjha » Unassigned
Issue summary: View changes
dewalt’s picture

dewalt commented
Status: Needs review » Needs work

@pradeepjha empty title area is shown when both title is empty and close button is hidden.

Also I think hook_update_N is needed to unset "Show close icon" property if title is empty in existing pop-ups to not provide visual changes to sites using the module.

Marty_S made their first commit to this issue’s fork.

  • dewalt committed cb3baef on 8.x-1.x 
    Issue #3204509 by dewalt: Close icon isn't shown if title is empty
dewalt’s picture

dewalt commented
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.