Closed (fixed)
Project:
Webform Pardot
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
18 Mar 2021 at 20:12 UTC
Updated:
12 Apr 2021 at 17:14 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
fjgarlin commentedPatch provided.
Comment #3
travis-bradbury commentedThanks fjgarlin. I like it, but I thought it'd be nice to have a test before committing it.
This patch changes the error message from "URL is invalid." to "The Pardot post url must be a valid URL.", which I think gives a bit more direction about what to do about the problem, as opposed to just saying that there is a problem. It also adds tests, but they don't work yet.
I'm getting this:
which is referring to the getHandler part of
I'm not sure what its problem is. Maybe the plugins are discovered and cached prior to the new plugin getting installed?
Maybe we should just commit it without that assertion, but it'd be annoying to have all that and not include an assertion that the configuration value is transformed correctly.
Comment #5
travis-bradbury commentedThe tests failed for a different reason than what I described in #3: the name of a webform configuration doesn't match its ID. Not sure why that didn't happen to me locally, but this should fix, and leave us with the issue described by #3.
Comment #7
fjgarlin commentedI gave it a go at testing the validation. I got these test to run, it's mostly based from your but extending the WebformBrowserTestBase class.
Patch attached.
Comment #9
travis-bradbury commentedAwesome, thanks a lot fjgarlin.