Problem/Motivation

\Drupal\commerce_ingenico\Plugin\Commerce\PaymentGateway\ECommerce::processFeedback() implements most of the business logic connecting Ingenico and the Commerce payment. However, this method cannot be overridden in a subclass to implement additional logic since it is declared as a private method.

Proposed resolution

Convert \Drupal\commerce_ingenico\Plugin\Commerce\PaymentGateway\ECommerce::processFeedback() to a protected method, so it can be overridden by a subclass.

Remaining tasks

  1. Write a patch
  2. Review
  3. Commit

User interface changes

None.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#2 3203996-2.patch695 bytesidebr

Comments

idebr created an issue. See original summary.

idebr’s picture

Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new695 bytes

Attached patch converts \Drupal\commerce_ingenico\Plugin\Commerce\PaymentGateway\ECommerce::processFeedback() to a protected method, so it can be overridden by a subclass.

flocondetoile’s picture

Status: Needs review » Reviewed & tested by the community

Agreed

  • idebr authored 30596a3 on 8.x-1.x
    Issue #3203996 by idebr, flocondetoile: Allow ECommerce::processFeedback...
flocondetoile’s picture

Status: Reviewed & tested by the community » Fixed

Committed. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.