Problem/Motivation

The form field machine name is "read_text_files_directly" but the default value tries to load "use_text_files_directly"

Steps to reproduce

Check the box and save, reload the page and the box won't be checked anymore.

Proposed resolution

Fix the default value key.

Remaining tasks

Update form.

User interface changes

N/A

API changes

N/A

Data model changes

N/A

Issue fork search_api_attachments-3203860

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

BramDriesen created an issue. See original summary.

bramdriesen’s picture

bramdriesen
he/him
Primary language Dutch
Location Belgium 🇧🇪🇪🇺
commented
Version: 8.x-1.x-dev » 9.0.x-dev

Should be merged to both 9.x as 8.x. Setting the highest versions as that's how it's supposed to go. After that a backport needs to be done, but since the branches are in line it will be easy to merge.

BramDriesen opened merge request !4

bramdriesen’s picture

bramdriesen
he/him
Primary language Dutch
Location Belgium 🇧🇪🇪🇺
commented
Status: Active » Needs review
bramdriesen’s picture

bramdriesen
he/him
Primary language Dutch
Location Belgium 🇧🇪🇪🇺
commented

Here is the patch URL that should also apply to 8.x since there is no difference. https://git.drupalcode.org/project/search_api_attachments/-/merge_reques...

izus’s picture

izus commented

ok thanks for this finding

  • izus committed 6ae4935 on 9.0.x authored by BramDriesen 
    Issue #3203860 by BramDriesen, izus: Wrong default value for...
izus’s picture

izus commented
Version: 9.0.x-dev » 8.x-1.x-dev

merged for 9.0.x

  • dc42538 committed on 8.x-1.x 
    Issue #3203860 by BramDriesen, izus: Wrong default value for...
izus’s picture

izus commented
Status: Needs review » Fixed

patch merged into 8.x-1.x too
thank you

bramdriesen’s picture

bramdriesen
he/him
Primary language Dutch
Location Belgium 🇧🇪🇪🇺
commented

No problem ;-) glad to help improve this module.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.