Support BlockContent entities

Looks like it needs a reroll.

Here's a re-roll of the patch which ignores the code standard stuff and the work from https://www.drupal.org/project/scanner/issues/3196119#comment-14028687

I'm realizing I don't know how to make a merge request based off another person's merge request! So just going with the old-fashioned patch method.

Reroll misses a fix to the Paragraph plugin that applies the parent's entitytype to the id key. Here's that bit as well.

One more bug I found: The undo function was trying to reset a node revision instead of the block revision.

#9 fails to patch the twig file, might need to be re-rolled.

  - Applying patches for drupal/scanner
    patches/scanner_support-blocks-3203383-9.patch (add support for sar'ing blocks)
patch '-p1' --no-backup-if-mismatch -d 'web/modules/contrib/scanner' < '/Users/marianocrivello/clones/pantheon/d8-ecompromotions/patches/scanner_support-blocks-3203383-9.patch'
patching file 'src/Plugin/Scanner/BlockContent.php'

patching file 'src/Plugin/Scanner/Node.php'

patching file 'src/Plugin/Scanner/Paragraph.php'

patching file 'templates/scanner-results.html.twig'

1 out of 1 hunks failed--saving rejects to 'templates/scanner-results.html.twig.rej'

patch '-p0' --no-backup-if-mismatch -d 'web/modules/contrib/scanner' < '/Users/marianocrivello/clones/pantheon/d8-ecompromotions/patches/scanner_support-blocks-3203383-9.patch'
patching file 'b/src/Plugin/Scanner/BlockContent.php'

Patch fixed from the latest updates. Should apply again.

#11 does not include #8 and #9 fixes. Here's a new one.

However, if the block is non-reusable (inline), the result's view/edit links point to an "access denied" page. In this case, it should point to the node containing the block. I'll try to implement this and submit a new patch.

This needs an accessCheck() on the entity query in order to be compatible with Drupal 10. See #3372857: Fix access check on query (Drupal 10 compatibility) which adds it for a Node query.

We're using this patch on a site that just got upgraded to D10 and scanner stopped working as a result of the lack of access checks in the scanner plugins.

I added the accessCheck().

Sorry, I messed up when creating the patch in #14.

The same change needs to be made to the replace() function. I'll try to come back to it again tonight.

I added the access check to the replace() function.

I think to speed up the fix here, it would be great to:

• Revert changes on the other entity types and create a separate issue for these changes
• Only add Block content support here (which totally makes sense as core entity)

Then I think this should be close to RTBC! Could someone do that?

Lets update for 2.0.x and add some test coverage please.

anybody, It's a good idea.

I also suggest resolving the issue with complex IDs {entityType}:{id} and the template first. This will prevent unnecessary work with MR rerolling. We have few issues with changes to the same conflicting files. Like this one 3196119

MR3 removes $query->accessCheck(FALSE);, it was added correctly in #17 patch

Hi all! Is #17 patch working to replace text within Layout builder blocks?

Let's focus this on blocks.

This will need a rewrite after the refactoring work is done - stay tuned for beta2.

We've simplified things so it was a lot easier to add a new entity. Thanks!