New role replacing previous values [#3203097]

Problem/Motivation

- Adding a new role overwrote the previous due to this line $roles = array_map(function($role) { return $role->target_id; }, $this->get('roles'));
- Also threw an error

Steps to reproduce

- Add a new role via the People view actions or programmatically

Proposed resolution

- Fix the use of $this->get('roles')

Comment	File	Size	Author
#5	domain_role-incorrect_get_roles-3203097-5.patch	1011 bytes	kimberleycgm
#3	domain_role-incorrect_get_roles-3203097-3.patch	840 bytes	kimberleycgm
#2	domain_role-incorrect_get_roles-3203097-2.patch	775 bytes	kimberleycgm

Comments

Comment #1

11 March 2021 at 19:21

kimberleycgm created an issue. See original summary.

Comment #2

kimberleycgm

she/her

English

commented 11 March 2021 at 19:22

Status:

Active

» Needs review

Status	File	Size
new	domain_role-incorrect_get_roles-3203097-2.patch	775 bytes

Comment #3

kimberleycgm

she/her

English

commented 16 March 2021 at 11:40

Status	File	Size
new	domain_role-incorrect_get_roles-3203097-3.patch	840 bytes

Updated the patch to use the same basic method the original code was using, just updated to the correct format. Previous patch was resulting in some users getting the 'anonymous' role when adding a role when creating a user using User::create()