Error: Call to a member function mainPropertyName() on null

Thanks for the patch.

Looking at the parent method, that is basically identical except that it already contains a similar check. This is probably leftover of the old media_entity days when we had to do this ourself.

I'd suggest you just remove the whole method and confirm that this fixes your problem.

FWIW, if you do get this error then it sounds like you have broken bynder media entities in your system, you might want to search for them and delete them, as they might break things elsewhere too.

Hi

I can confirm that removing the method solves the problem.

The core method in D9.2 will allow for a source field with zero items:

  /**
   * {@inheritdoc}
   */
  public function getSourceFieldValue(MediaInterface $media) {
    $source_field = $this->configuration['source_field'];
    if (empty($source_field)) {
      throw new \RuntimeException('Source field for media source is not defined.');
    }

    $items = $media->get($source_field);
    if ($items->isEmpty()) {
      return NULL;
    }

    $field_item = $items->first();
    return $field_item->{$field_item->mainPropertyName()};
  }

The helper method that's bundled with the module doesn't:

  /**
   * Get the primary value stored in the source field.
   *
   * @todo This helper method was added to MediaSourceBase in 8.5.0 but we
   * replicate it here because we want to support 8.4.0 sites as well. This
   * method can be safely removed once there is no need to support 8.4 anymore,
   * and we ensure the core Media dependency is bumped to 8.5.0 at least.
   *
   * @param \Drupal\media\MediaInterface $media
   *   A media item.
   *
   * @return mixed
   *   The source value.
   *
   * @throws \RuntimeException
   *   If the source field for the media source is not defined.
   */
  public function getSourceFieldValue(MediaInterface $media) {
    $source_field = $this->configuration['source_field'];
    if (empty($source_field)) {
      throw new \RuntimeException('Source field for media source is not defined.');
    }

    /** @var \Drupal\Core\Field\FieldItemInterface $field_item */
    $field_item = $media->get($source_field)->first();
    return $field_item->{$field_item->mainPropertyName()};
  }

@berdir are you happy for me to create a patch to remove the full method?

Here's a patch in any case :)

The patch in #9 is almost identical to my merge request in #6. It just misses the increased dependency version.

Hi @JvE

Sorry, I missed that.

Looks good :)

Best

Luke

That requirement is unnecessary though because in the very same .info.yml, we already require drupal core ^8.8 || 9, so there's no way that you could have drupal:media 8.4.

Accidently merged the MR and reverted the .info.yml change again.