Refactor group content access result into protected sub method

I'd go about this differently:

• Create a new method like combinedPermissionsCheck() that expects an array of permissions.
• In combinedPermissionCheck(), wrap the single permission in an array and hand it off to combinedPermissionsCheck()
• Deprecate combinedPermissionCheck()
• Now remove the explicit addition of the admin permission in relationAccess() and entityAccess() and have them call combinedPermissionsCheck() also

This means we only have one protected "permission check method" and it's called consistently from all 4 public methods.

+++ b/src/Plugin/GroupContentAccessControlHandler.php
@@ -183,8 +175,68 @@ class GroupContentAccessControlHandler extends GroupContentHandlerBase implement
-    return $this->combinedPermissionCheck($group, $account, $permission, $return_as_object);

We can't stop calling the original one. That would be a BC break. We need to mark the original as deprecated, but keep calling it (as a wrapper ar0und the new one) until 2.0

Suppose I read the code and instead of overwriting relationCreateAccess and entityCreateAccess, I chose to overwrite combinedPermissionCheck(). Now that method is not being called at all any more, so my overrides all of a sudden get ignored.

That's a BC break.

This is what I had in mind. (Note I did not pass along the operation like you did, feel free to add that in)