Closed (fixed)
Project:
Commerce TrustedShops
Version:
8.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
4 Mar 2021 at 08:06 UTC
Updated:
30 Apr 2021 at 08:49 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
aerzas commentedHere is a patch proposition.
Comment #3
aerzas commentedComment #4
aerzas commentedComment #5
aerzas commentedHere is a further proposition to open product data to alterations via the event dispatcher.
Comment #6
wengerkThank you for that huge improvements !!
I opened a PR on Github with that patch to run Tests & Code Styles on Github Actions (faster than Drupal CI).
https://github.com/antistatique/drupal-commerce-trustedshops/pull/11
We still have some tests issues to works on before merging.
Comment #7
aerzas commentedHere is the updated patch with the fixed kernel tests.
Comment #8
aerzas commentedRe-roll patch against latest changes.
Comment #9
aerzas commentedComment #10
wengerkFor me the code is pretty perfect ! Many thanks for that huge quality code !!
Still, before merging, I would have a tests that cover the following code
Indeed, the current tests show how works
AlterProductDataEventbut nothing demonstrate the event is fired properly.Comment #11
aerzas commentedThank you very much for your feedback.
Here is the updated patch with an additional test on the fired event.
Comment #12
aerzas commentedFixing wrong import.
Comment #13
aerzas commentedComment #14
wengerkThanks Aerzas !
I added another tests that ensure
Drupal\commerce_trustedshops\API\Review::triggerShopReviewwork with a order item without purchased entity.Comment #16
wengerk