Problem/Motivation

#2915322: Image styles: Error generating image, missing source file. is hidding the fault that files that exist on S3FS but do not exist in the database are being accessed.

This additionally in the right combination of a file missing on S3 and in s3fs_file could cause a significant load hit to S3 and performance hit to Drupal.

Steps to reproduce

Populate S3, truncate the s3fs_table, access files, s3fs is able to access the files

Proposed resolution

Verify we have a good metadata sync ability. Should work from Drush and from the web UI.

This also requires that copy from local to s3:// works as designed.

Remaining tasks

#3154241: 504 timeout on very large S3 buckets, make refresh cache action use batch process
#2986407: s3fs-refresh-cache is not scalable
#3090600: S3 File System drush s3fs-copy-local and also copy local public file to s3 in Admin Config form in action tab not working (Not a direct blocker but some of the issues it hits may impact us in the other issues)
#2823409: S3FS Ignores its database limit on URI length.
#3202909: File migration does not update database entries from s3://prefix
Revert #2915322: Image styles: Error generating image, missing source file.

User interface changes

TBD

API changes

TBD

Data model changes

TBD

CommentFileSizeAuthor
#4 disallow_realtime_un-3201248-4.patch1.58 KBcmlara

Comments

cmlara created an issue. See original summary.

cmlara’s picture

cmlara’s picture

Issue summary: View changes
cmlara’s picture

Status: Active » Needs review
Related issues: +#3202909: File migration does not update database entries from s3://prefix
StatusFileSize
new1.58 KB

And with all the requirements done for basic implementation of this I think we are ready for the patch.

This will rollback the changes in #2915322: Image styles: Error generating image, missing source file. that still exist that were related to doing real time lookups for files that are not in the metdata cache.

Once again the s3fs_file table will be the official 'source of truth' for s3fs file structure.

  • cmlara committed c528134 on 8.x-3.x
    Issue #3201248: Disallow realtime unknown file lookup to S3
    
    Partially...
cmlara’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.