Problem/Motivation

The hook_help docs give an example that shows no return statement if help does not apply: https://api.drupal.org/api/drupal/core%21modules%21help%21help.api.php/f...

The way this module currently works is it always returns t(''). This causes the help block to display. This can have adverse affects for a site's look/design.

Steps to reproduce

Enable this module.
Inspect the markup for the help block and notice it displays with no contents.

Proposed resolution

Remove the return statement in d8_google_optimize_hide_page_help.

Remaining tasks

None

User interface changes

None

API changes

None

Data model changes

None

CommentFileSizeAuthor
#2 d8_google_optimize_hide_page.unnecessary_help_block.3201041.2.patch438 bytespcfoster

Comments

josephdpurcell created an issue. See original summary.

pcfoster’s picture

pcfoster commented
Status: Active » Needs review
StatusFileSize
new d8_google_optimize_hide_page.unnecessary_help_block.3201041.2.patch438 bytes

Removing the return t('') that causes an empty help block to display.

josephdpurcell’s picture

josephdpurcell commented
Status: Needs review » Reviewed & tested by the community

I applied patch from #2 and it resolved the issue: an empty help block no longer displays on the home page.

  • webfaqtory committed 148ea30 on 8.x-1.x authored by pcfoster 
    Issue #3201041 by pcfoster: Help function causes help block to display...
webfaqtory’s picture

webfaqtory commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.